diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:28:58 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:54:43 +0000 |
commit | e57ca02849c3d87142ff5ff9099a212e72b8139c (patch) | |
tree | bcce66b27261553c308779f3e8663a269ed3a671 /framework/source/tabwin | |
parent | 8802ebd5172ec4bc412a59d136c82b77ab452281 (diff) |
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'framework/source/tabwin')
-rw-r--r-- | framework/source/tabwin/tabwindow.cxx | 28 | ||||
-rw-r--r-- | framework/source/tabwin/tabwinfactory.cxx | 2 |
2 files changed, 1 insertions, 29 deletions
diff --git a/framework/source/tabwin/tabwindow.cxx b/framework/source/tabwin/tabwindow.cxx index f92628f81597..6d92e2fcbde4 100644 --- a/framework/source/tabwin/tabwindow.cxx +++ b/framework/source/tabwin/tabwindow.cxx @@ -257,7 +257,6 @@ IMPL_LINK( TabWindow, Deactivate, TabControl*, pTabControl, bool ) // XInitialization void SAL_CALL TabWindow::initialize( const css::uno::Sequence< css::uno::Any >& aArguments ) -throw (css::uno::Exception, css::uno::RuntimeException, std::exception) { const OUString aTopWindowArgName( "TopWindow" ); const OUString aSizeArgName( "Size" ); @@ -411,7 +410,7 @@ throw (css::uno::Exception, css::uno::RuntimeException, std::exception) // XComponent -void SAL_CALL TabWindow::dispose() throw (css::uno::RuntimeException, std::exception) +void SAL_CALL TabWindow::dispose() { // Send message to all listener and forget her references. css::uno::Reference< css::lang::XComponent > xThis( @@ -451,7 +450,6 @@ void SAL_CALL TabWindow::dispose() throw (css::uno::RuntimeException, std::excep } void SAL_CALL TabWindow::addEventListener( const css::uno::Reference< css::lang::XEventListener >& xListener ) -throw (css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -464,7 +462,6 @@ throw (css::uno::RuntimeException, std::exception) } void SAL_CALL TabWindow::removeEventListener( const css::uno::Reference< css::lang::XEventListener >& xListener ) -throw (css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -479,25 +476,21 @@ throw (css::uno::RuntimeException, std::exception) // XEventListener void SAL_CALL TabWindow::disposing( const css::lang::EventObject& ) -throw( css::uno::RuntimeException, std::exception ) { } // XWindowListener void SAL_CALL TabWindow::windowResized( const css::awt::WindowEvent& ) -throw( css::uno::RuntimeException, std::exception ) { implts_LayoutWindows(); } void SAL_CALL TabWindow::windowMoved( const css::awt::WindowEvent& ) -throw( css::uno::RuntimeException, std::exception ) { } void SAL_CALL TabWindow::windowShown( const css::lang::EventObject& ) -throw( css::uno::RuntimeException, std::exception ) { SolarMutexGuard g; @@ -514,7 +507,6 @@ throw( css::uno::RuntimeException, std::exception ) } void SAL_CALL TabWindow::windowHidden( const css::lang::EventObject& ) -throw( css::uno::RuntimeException, std::exception ) { SolarMutexGuard g; if ( m_xContainerWindow.is() ) @@ -532,12 +524,10 @@ throw( css::uno::RuntimeException, std::exception ) // XTopWindowListener void SAL_CALL TabWindow::windowOpened( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } void SAL_CALL TabWindow::windowClosing( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { css::uno::Reference< css::lang::XComponent > xComponent( static_cast<OWeakObject *>(this), css::uno::UNO_QUERY ); if ( xComponent.is() ) @@ -545,34 +535,28 @@ throw (css::uno::RuntimeException, std::exception) } void SAL_CALL TabWindow::windowClosed( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } void SAL_CALL TabWindow::windowMinimized( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } void SAL_CALL TabWindow::windowNormalized( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } void SAL_CALL TabWindow::windowActivated( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } void SAL_CALL TabWindow::windowDeactivated( const css::lang::EventObject& ) -throw (css::uno::RuntimeException, std::exception) { } // XSimpleTabController ::sal_Int32 SAL_CALL TabWindow::insertTab() -throw (css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -595,7 +579,6 @@ throw (css::uno::RuntimeException, std::exception) } void SAL_CALL TabWindow::removeTab( ::sal_Int32 ID ) -throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -624,7 +607,6 @@ throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::ex } void SAL_CALL TabWindow::setTabProps( ::sal_Int32 ID, const css::uno::Sequence< css::beans::NamedValue >& Properties ) -throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -670,7 +652,6 @@ throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::ex } css::uno::Sequence< css::beans::NamedValue > SAL_CALL TabWindow::getTabProps( ::sal_Int32 ID ) -throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::exception) { SolarMutexGuard g; @@ -703,7 +684,6 @@ throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::ex } void SAL_CALL TabWindow::activateTab( ::sal_Int32 ID ) -throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -736,7 +716,6 @@ throw (css::lang::IndexOutOfBoundsException, css::uno::RuntimeException, std::ex } ::sal_Int32 SAL_CALL TabWindow::getActiveTabID() -throw (css::uno::RuntimeException, std::exception) { SolarMutexGuard g; @@ -758,7 +737,6 @@ throw (css::uno::RuntimeException, std::exception) void SAL_CALL TabWindow::addTabListener( const css::uno::Reference< css::awt::XTabListener >& xListener ) -throw (css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -772,7 +750,6 @@ throw (css::uno::RuntimeException, std::exception) } void SAL_CALL TabWindow::removeTabListener( const css::uno::Reference< css::awt::XTabListener >& xListener ) -throw (css::uno::RuntimeException, std::exception) { /* SAFE AREA ----------------------------------------------------------------------------------------------- */ SolarMutexClearableGuard aLock; @@ -792,7 +769,6 @@ sal_Bool SAL_CALL TabWindow::convertFastPropertyValue( css::uno::Any& aCon css::uno::Any& aOldValue , sal_Int32 nHandle , const css::uno::Any& aValue ) -throw( css::lang::IllegalArgumentException ) { // Initialize state with sal_False !!! // (Handle can be invalid) @@ -823,7 +799,6 @@ throw( css::lang::IllegalArgumentException ) void SAL_CALL TabWindow::setFastPropertyValue_NoBroadcast( sal_Int32, const css::uno::Any&) -throw( css::uno::Exception, std::exception ) { } @@ -868,7 +843,6 @@ void SAL_CALL TabWindow::getFastPropertyValue( css::uno::Any& aValue , } css::uno::Reference< css::beans::XPropertySetInfo > SAL_CALL TabWindow::getPropertySetInfo() -throw ( css::uno::RuntimeException, std::exception ) { // Optimize this method ! // We initialize a static variable only one time. And we don't must use a mutex at every call! diff --git a/framework/source/tabwin/tabwinfactory.cxx b/framework/source/tabwin/tabwinfactory.cxx index e343a78b2a1d..87e3f23340f6 100644 --- a/framework/source/tabwin/tabwinfactory.cxx +++ b/framework/source/tabwin/tabwinfactory.cxx @@ -60,7 +60,6 @@ TabWinFactory::~TabWinFactory() css::uno::Reference< css::uno::XInterface > SAL_CALL TabWinFactory::createInstanceWithContext( const css::uno::Reference< css::uno::XComponentContext >& xContext ) -throw ( css::uno::Exception, css::uno::RuntimeException, std::exception ) { css::uno::Sequence< css::uno::Any > aArgs; @@ -69,7 +68,6 @@ throw ( css::uno::Exception, css::uno::RuntimeException, std::exception ) css::uno::Reference< css::uno::XInterface > SAL_CALL TabWinFactory::createInstanceWithArgumentsAndContext( const css::uno::Sequence< css::uno::Any >& Arguments, const css::uno::Reference< css::uno::XComponentContext >& ) -throw ( css::uno::Exception, css::uno::RuntimeException, std::exception ) { const OUString aTopWindowArgName( "TopWindow"); |