diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 11:47:51 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-28 14:51:56 +0200 |
commit | b09deb075319c1c19f91e3a6f64429b61682ebf8 (patch) | |
tree | 9e73d1e63092083a337a4ddf1dfe962b4f6ef4dc /framework | |
parent | 587d6e13df7bb9c8f78ce605ebb8f8fd34b85a2c (diff) |
loplugin:constparams handle constructors
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis
Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework')
-rw-r--r-- | framework/inc/uielement/menubarmanager.hxx | 4 | ||||
-rw-r--r-- | framework/inc/xml/saxnamespacefilter.hxx | 2 | ||||
-rw-r--r-- | framework/inc/xml/toolboxdocumenthandler.hxx | 2 | ||||
-rw-r--r-- | framework/source/fwe/xml/saxnamespacefilter.cxx | 2 | ||||
-rw-r--r-- | framework/source/fwe/xml/toolboxdocumenthandler.cxx | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/framework/inc/uielement/menubarmanager.hxx b/framework/inc/uielement/menubarmanager.hxx index 77cb087f4f5a..bc782dbeda95 100644 --- a/framework/inc/uielement/menubarmanager.hxx +++ b/framework/inc/uielement/menubarmanager.hxx @@ -153,8 +153,8 @@ class MenuBarManager: struct MenuItemHandler { MenuItemHandler( sal_uInt16 aItemId, - css::uno::Reference< css::frame::XStatusListener >& xManager, - css::uno::Reference< css::frame::XDispatch >& rDispatch ) : + css::uno::Reference< css::frame::XStatusListener > const & xManager, + css::uno::Reference< css::frame::XDispatch > const & rDispatch ) : nItemId( aItemId ), xSubMenuManager( xManager ), xMenuItemDispatch( rDispatch ) {} diff --git a/framework/inc/xml/saxnamespacefilter.hxx b/framework/inc/xml/saxnamespacefilter.hxx index 3bea6c2380f8..c7a5041af7e2 100644 --- a/framework/inc/xml/saxnamespacefilter.hxx +++ b/framework/inc/xml/saxnamespacefilter.hxx @@ -36,7 +36,7 @@ class FWE_DLLPUBLIC SaxNamespaceFilter : public ::cppu::WeakImplHelper< css::xml::sax::XDocumentHandler > { public: - SaxNamespaceFilter( css::uno::Reference< css::xml::sax::XDocumentHandler >& rSax1DocumentHandler ); + SaxNamespaceFilter( css::uno::Reference< css::xml::sax::XDocumentHandler > const & rSax1DocumentHandler ); virtual ~SaxNamespaceFilter() override; // XDocumentHandler diff --git a/framework/inc/xml/toolboxdocumenthandler.hxx b/framework/inc/xml/toolboxdocumenthandler.hxx index 36da36b9294c..7dc7133ec337 100644 --- a/framework/inc/xml/toolboxdocumenthandler.hxx +++ b/framework/inc/xml/toolboxdocumenthandler.hxx @@ -121,7 +121,7 @@ class FWE_DLLPUBLIC OWriteToolBoxDocumentHandler final public: OWriteToolBoxDocumentHandler( const css::uno::Reference< css::container::XIndexAccess >& rItemAccess, - css::uno::Reference< css::xml::sax::XDocumentHandler >& rDocumentHandler ); + css::uno::Reference< css::xml::sax::XDocumentHandler > const & rDocumentHandler ); ~OWriteToolBoxDocumentHandler(); /// @throws css::xml::sax::SAXException diff --git a/framework/source/fwe/xml/saxnamespacefilter.cxx b/framework/source/fwe/xml/saxnamespacefilter.cxx index f2f8169b3258..fc498248c987 100644 --- a/framework/source/fwe/xml/saxnamespacefilter.cxx +++ b/framework/source/fwe/xml/saxnamespacefilter.cxx @@ -35,7 +35,7 @@ using namespace ::com::sun::star::uno; namespace framework{ -SaxNamespaceFilter::SaxNamespaceFilter( Reference< XDocumentHandler >& rSax1DocumentHandler ) : +SaxNamespaceFilter::SaxNamespaceFilter( Reference< XDocumentHandler > const & rSax1DocumentHandler ) : m_xLocator( nullptr ), xDocumentHandler( rSax1DocumentHandler ), m_aXMLAttributeNamespace( "xmlns" ), diff --git a/framework/source/fwe/xml/toolboxdocumenthandler.cxx b/framework/source/fwe/xml/toolboxdocumenthandler.cxx index 633a057c574a..50fc7dfe4ad2 100644 --- a/framework/source/fwe/xml/toolboxdocumenthandler.cxx +++ b/framework/source/fwe/xml/toolboxdocumenthandler.cxx @@ -583,7 +583,7 @@ OUString OReadToolBoxDocumentHandler::getErrorLineString() OWriteToolBoxDocumentHandler::OWriteToolBoxDocumentHandler( const Reference< XIndexAccess >& rItemAccess, - Reference< XDocumentHandler >& rWriteDocumentHandler ) : + Reference< XDocumentHandler > const & rWriteDocumentHandler ) : m_xWriteDocumentHandler( rWriteDocumentHandler ), m_rItemAccess( rItemAccess ) { |