loplugin:checkunusedparams

the "check for taking address of function" part was generating false+

Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f
Reviewed-on: https://gerrit.libreoffice.org/40613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 12 insertions, 20 deletions

diff --git a/framework/inc/dispatch/mailtodispatcher.hxx b/framework/inc/dispatch/mailtodispatcher.hxx
index bc3fc2f68717..afcea61455b9 100644
--- a/framework/inc/dispatch/mailtodispatcher.hxx
+++ b/framework/inc/dispatch/mailtodispatcher.hxx
@@ -93,8 +93,7 @@ class MailToDispatcher : public  ::cppu::WeakImplHelper<
     /* internal */
     private:
         /// @throws css::uno::RuntimeException
-        bool implts_dispatch( const css::util::URL&                                  aURL       ,
-                                  const css::uno::Sequence< css::beans::PropertyValue >& lArguments );
+        bool implts_dispatch( const css::util::URL& aURL );
 
 };      //  class MailToDispatcher
 
diff --git a/framework/inc/dispatch/servicehandler.hxx b/framework/inc/dispatch/servicehandler.hxx
index fd225ea7111a..c8fd1ec24de6 100644
--- a/framework/inc/dispatch/servicehandler.hxx
+++ b/framework/inc/dispatch/servicehandler.hxx
@@ -97,8 +97,7 @@ class ServiceHandler : public  ::cppu::WeakImplHelper<
     /* internal */
     private:
         /// @throws css::uno::RuntimeException
-        css::uno::Reference< css::uno::XInterface > implts_dispatch( const css::util::URL&                                  aURL       ,
-                                                                     const css::uno::Sequence< css::beans::PropertyValue >& lArguments );
+        css::uno::Reference< css::uno::XInterface > implts_dispatch( const css::util::URL& aURL );
 
 };      //  class ServiceHandler
 
diff --git a/framework/source/dispatch/mailtodispatcher.cxx b/framework/source/dispatch/mailtodispatcher.cxx
index 904b5416048e..37c5321c747b 100644
--- a/framework/source/dispatch/mailtodispatcher.cxx
+++ b/framework/source/dispatch/mailtodispatcher.cxx
@@ -115,12 +115,12 @@ css::uno::Sequence< css::uno::Reference< css::frame::XDispatch > > SAL_CALL Mail
                     list of optional arguments for this mail request
 */
 void SAL_CALL MailToDispatcher::dispatch( const css::util::URL&                                  aURL       ,
-                                          const css::uno::Sequence< css::beans::PropertyValue >& lArguments )
+                                          const css::uno::Sequence< css::beans::PropertyValue >& /*lArguments*/ )
 {
     // dispatch() is an [oneway] call ... and may our user release his reference to us immediately.
     // So we should hold us self alive till this call ends.
     css::uno::Reference< css::frame::XNotifyingDispatch > xSelfHold(static_cast< ::cppu::OWeakObject* >(this), css::uno::UNO_QUERY);
-    implts_dispatch(aURL,lArguments);
+    implts_dispatch(aURL);
     // No notification for status listener!
 }
 
@@ -137,7 +137,7 @@ void SAL_CALL MailToDispatcher::dispatch( const css::util::URL&
                     reference to a valid listener for state events
 */
 void SAL_CALL MailToDispatcher::dispatchWithNotification( const css::util::URL&                                             aURL      ,
-                                                          const css::uno::Sequence< css::beans::PropertyValue >&            lArguments,
+                                                          const css::uno::Sequence< css::beans::PropertyValue >&            /*lArguments*/,
                                                           const css::uno::Reference< css::frame::XDispatchResultListener >& xListener )
 {
     // This class was designed to die by reference. And if user release his reference to us immediately after calling this method
@@ -145,7 +145,7 @@ void SAL_CALL MailToDispatcher::dispatchWithNotification( const css::util::URL&
     // Another reason: We can use this reference as source of sending event at the end too.
     css::uno::Reference< css::frame::XNotifyingDispatch > xThis(static_cast< ::cppu::OWeakObject* >(this), css::uno::UNO_QUERY);
 
-    bool bState = implts_dispatch(aURL,lArguments);
+    bool bState = implts_dispatch(aURL);
     if (xListener.is())
     {
         css::frame::DispatchResultEvent aEvent;
@@ -167,16 +167,13 @@ void SAL_CALL MailToDispatcher::dispatchWithNotification( const css::util::URL&
 
     @param      aURL
                     mail URL which should be executed
-    @param      lArguments
-                    list of optional arguments for this mail request
 
     @return     <TRUE/> if dispatch could be started successfully
                 Note: Our internal used shell executor doesn't return any state value - so we must
                 believe that call was successfully.
                 <FALSE/> if necessary resource couldn't be created or an exception was thrown.
 */
-bool MailToDispatcher::implts_dispatch( const css::util::URL&                                  aURL       ,
-                                            const css::uno::Sequence< css::beans::PropertyValue >& /*lArguments*/ )
+bool MailToDispatcher::implts_dispatch( const css::util::URL& aURL )
 {
     bool bSuccess = false;
 
diff --git a/framework/source/dispatch/servicehandler.cxx b/framework/source/dispatch/servicehandler.cxx
index d1f7bd6f636a..b1046a90d7a5 100644
--- a/framework/source/dispatch/servicehandler.cxx
+++ b/framework/source/dispatch/servicehandler.cxx
@@ -114,12 +114,12 @@ css::uno::Sequence< css::uno::Reference< css::frame::XDispatch > > SAL_CALL Serv
                     list of optional arguments for this request
 */
 void SAL_CALL ServiceHandler::dispatch( const css::util::URL&                                  aURL       ,
-                                    const css::uno::Sequence< css::beans::PropertyValue >& lArguments )
+                                        const css::uno::Sequence< css::beans::PropertyValue >& /*lArguments*/ )
 {
     // dispatch() is an [oneway] call ... and may our user release his reference to us immediately.
     // So we should hold us self alive till this call ends.
     css::uno::Reference< css::frame::XNotifyingDispatch > xSelfHold(static_cast< ::cppu::OWeakObject* >(this), css::uno::UNO_QUERY);
-    implts_dispatch(aURL,lArguments);
+    implts_dispatch(aURL);
     // No notification for status listener!
 }
 
@@ -136,7 +136,7 @@ void SAL_CALL ServiceHandler::dispatch( const css::util::URL&
                     optional listener for state events
 */
 void SAL_CALL ServiceHandler::dispatchWithNotification( const css::util::URL&                                             aURL      ,
-                                                        const css::uno::Sequence< css::beans::PropertyValue >&            lArguments,
+                                                        const css::uno::Sequence< css::beans::PropertyValue >&            /*lArguments*/,
                                                         const css::uno::Reference< css::frame::XDispatchResultListener >& xListener )
 {
     // This class was designed to die by reference. And if user release his reference to us immediately after calling this method
@@ -144,7 +144,7 @@ void SAL_CALL ServiceHandler::dispatchWithNotification( const css::util::URL&
     // Another reason: We can use this reference as source of sending event at the end too.
     css::uno::Reference< css::frame::XNotifyingDispatch > xThis(static_cast< ::cppu::OWeakObject* >(this), css::uno::UNO_QUERY);
 
-    css::uno::Reference< css::uno::XInterface > xService = implts_dispatch(aURL,lArguments);
+    css::uno::Reference< css::uno::XInterface > xService = implts_dispatch(aURL);
     if (xListener.is())
     {
         css::frame::DispatchResultEvent aEvent;
@@ -167,15 +167,12 @@ void SAL_CALL ServiceHandler::dispatchWithNotification( const css::util::URL&
 
     @param      aURL
                     uno URL which should be executed
-    @param      lArguments
-                    list of optional arguments for this request
 
     @return     <NULL/> if requested service couldn't be created successfully;
                 a valid reference otherwise. This return value can be used to indicate,
                 if dispatch was successfully or not.
 */
-css::uno::Reference< css::uno::XInterface > ServiceHandler::implts_dispatch( const css::util::URL&                                  aURL       ,
-                                                                             const css::uno::Sequence< css::beans::PropertyValue >& /*lArguments*/ )
+css::uno::Reference< css::uno::XInterface > ServiceHandler::implts_dispatch( const css::util::URL& aURL )
 {
     if (!m_xFactory.is())
         return css::uno::Reference< css::uno::XInterface >();