diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-01-24 09:08:34 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-11 13:25:31 +0100 |
commit | 0d1253c2328106a443d16b6c8e96347de33e2ace (patch) | |
tree | e26e7ca9f9b91f50573f446b8a93515f4c4302eb /framework | |
parent | 2dd7aba7564a222c2acbac22975a76a6ab33c41f (diff) |
new loplugin writeonlyvars
largely based on the relevant portion of the unusedfields loplugin, but
adapted for local vars
Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1
Reviewed-on: https://gerrit.libreoffice.org/66835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework')
-rw-r--r-- | framework/source/layoutmanager/layoutmanager.cxx | 5 | ||||
-rw-r--r-- | framework/source/uielement/menubarmanager.cxx | 3 | ||||
-rw-r--r-- | framework/source/uielement/statusbarmanager.cxx | 5 | ||||
-rw-r--r-- | framework/source/uielement/toolbarmerger.cxx | 2 | ||||
-rw-r--r-- | framework/source/uielement/uicommanddescription.cxx | 3 |
5 files changed, 0 insertions, 18 deletions
diff --git a/framework/source/layoutmanager/layoutmanager.cxx b/framework/source/layoutmanager/layoutmanager.cxx index 749562d29245..ae58c71deb72 100644 --- a/framework/source/layoutmanager/layoutmanager.cxx +++ b/framework/source/layoutmanager/layoutmanager.cxx @@ -2662,11 +2662,6 @@ IMPL_LINK_NOARG(LayoutManager, AsyncLayoutHdl, Timer *, void) if( !m_xContainerWindow.is() ) return; - awt::Rectangle aDockingArea( m_aDockingArea ); - ::Size aStatusBarSize( implts_getStatusBarSize() ); - - // Subtract status bar height - aDockingArea.Height -= aStatusBarSize.Height(); aReadLock.clear(); implts_setDockingAreaWindowSizes(); diff --git a/framework/source/uielement/menubarmanager.cxx b/framework/source/uielement/menubarmanager.cxx index 530977a590f1..2638f9a8c022 100644 --- a/framework/source/uielement/menubarmanager.cxx +++ b/framework/source/uielement/menubarmanager.cxx @@ -1415,7 +1415,6 @@ void MenuBarManager::FillMenu( Sequence< PropertyValue > aProp; OUString aCommandURL; OUString aLabel; - OUString aHelpURL; OUString aModuleIdentifier( rModuleIdentifier ); sal_uInt16 nType = 0; Reference< XIndexAccess > xIndexContainer; @@ -1433,8 +1432,6 @@ void MenuBarManager::FillMenu( OUString aPropName = aProp[i].Name; if ( aPropName == "CommandURL" ) aProp[i].Value >>= aCommandURL; - else if ( aPropName == "HelpURL" ) - aProp[i].Value >>= aHelpURL; else if ( aPropName == "ItemDescriptorContainer" ) aProp[i].Value >>= xIndexContainer; else if ( aPropName == "Label" ) diff --git a/framework/source/uielement/statusbarmanager.cxx b/framework/source/uielement/statusbarmanager.cxx index 0ab6b555ad9f..219f54cc2016 100644 --- a/framework/source/uielement/statusbarmanager.cxx +++ b/framework/source/uielement/statusbarmanager.cxx @@ -413,7 +413,6 @@ void StatusBarManager::FillStatusBar( const uno::Reference< container::XIndexAcc { uno::Sequence< beans::PropertyValue > aProp; OUString aCommandURL; - OUString aHelpURL; sal_Int16 nOffset( 0 ); sal_Int16 nStyle( 0 ); sal_Int16 nWidth( 0 ); @@ -429,10 +428,6 @@ void StatusBarManager::FillStatusBar( const uno::Reference< container::XIndexAcc { aProp[i].Value >>= aCommandURL; } - else if ( aProp[i].Name == "HelpURL" ) - { - aProp[i].Value >>= aHelpURL; - } else if ( aProp[i].Name == "Style" ) { aProp[i].Value >>= nStyle; diff --git a/framework/source/uielement/toolbarmerger.cxx b/framework/source/uielement/toolbarmerger.cxx index 75cce49b15a2..83416bc5daea 100644 --- a/framework/source/uielement/toolbarmerger.cxx +++ b/framework/source/uielement/toolbarmerger.cxx @@ -435,7 +435,6 @@ void ToolBarMerger::MergeItems( { const sal_Int32 nSize( rAddonToolbarItems.size() ); - sal_uInt16 nIndex( 0 ); for ( sal_Int32 i = 0; i < nSize; i++ ) { const AddonToolbarItem& rItem = rAddonToolbarItems[i]; @@ -469,7 +468,6 @@ void ToolBarMerger::MergeItems( ToolBarMerger::CreateToolbarItem( pToolbar, nInsPos, rItemId, rItem ); } - ++nIndex; ++rItemId; } } diff --git a/framework/source/uielement/uicommanddescription.cxx b/framework/source/uielement/uicommanddescription.cxx index 547a035b088e..02e41f47fcb3 100644 --- a/framework/source/uielement/uicommanddescription.cxx +++ b/framework/source/uielement/uicommanddescription.cxx @@ -182,8 +182,6 @@ ConfigurationAccess_UICommand::~ConfigurationAccess_UICommand() // XNameAccess Any ConfigurationAccess_UICommand::getByNameImpl( const OUString& rCommandURL ) { - static sal_Int32 nRequests = 0; - osl::MutexGuard g(m_aMutex); if ( !m_bConfigAccessInitialized ) { @@ -210,7 +208,6 @@ Any ConfigurationAccess_UICommand::getByNameImpl( const OUString& rCommandURL ) else { // SAFE - ++nRequests; return getInfoFromCommand( rCommandURL ); } } |