diff options
| author | Maxim Monastirsky <momonasmon@gmail.com> | 2020-08-26 17:14:48 +0300 |
|---|---|---|
| committer | Maxim Monastirsky <momonasmon@gmail.com> | 2020-08-27 21:28:16 +0200 |
| commit | 03fe80f43c8210c81a41b84bbf5dc7ad17b2a6b2 (patch) | |
| tree | 47ce4dc6326086cf9d7d9f63b9dfc68097a91aa7 /framework | |
| parent | e9fc3f69cf3c677db5fc5203e95e9d21528dc888 (diff) | |
Command icon changes not reflected in menus
Regression of commit 7383ab517030db0c2d7bf4f393f38743fbcaba04
("loplugin:constantparam in f*").
To reproduce from UI:
1. Start Writer with gen.
2. Open the File menu at least once (so m_bRetrieveImages set to false).
3. Right click on the Standard toolbar > Customize Toolbar...
4. Right click the Open toolbar button > Change Icon..., pick some new
icon, and confirm the changes.
5. Open the File menu and notice that the Open... item there still has
the old icon.
Change-Id: I89ba87aafc56192dc150741244d5cd7c6f7923e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101443
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Diffstat (limited to 'framework')
| -rw-r--r-- | framework/source/uielement/menubarmanager.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/framework/source/uielement/menubarmanager.cxx b/framework/source/uielement/menubarmanager.cxx index 21a4c82b731b..5359bc712f53 100644 --- a/framework/source/uielement/menubarmanager.cxx +++ b/framework/source/uielement/menubarmanager.cxx @@ -232,8 +232,7 @@ void SAL_CALL MenuBarManager::elementInserted( const css::ui::ConfigurationEvent return; sal_Int16 nImageType = sal_Int16(); - if (( Event.aInfo >>= nImageType ) && - ( nImageType == css::ui::ImageType::SIZE_LARGE )) + if (( Event.aInfo >>= nImageType ) && nImageType == 0 ) RequestImages(); } |