diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2014-03-18 09:09:29 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2014-03-18 09:43:16 +0100 |
commit | faef574c5572035cbc7808a52e80ff946bc745cd (patch) | |
tree | 01b5ecabc3ac4f4cd0a3e364bbf057adeafe9678 /framework | |
parent | 9a67d4f419a3487b553441aa49361e7d07a0614b (diff) |
Access safe data members directly
Change-Id: I077318a2ecb9b3d9708930742c458422aadeb064
Diffstat (limited to 'framework')
-rw-r--r-- | framework/inc/dispatch/dispatchinformationprovider.hxx | 4 | ||||
-rw-r--r-- | framework/source/dispatch/dispatchinformationprovider.cxx | 16 |
2 files changed, 5 insertions, 15 deletions
diff --git a/framework/inc/dispatch/dispatchinformationprovider.hxx b/framework/inc/dispatch/dispatchinformationprovider.hxx index 1f5fcb23c9f4..66af207c0531 100644 --- a/framework/inc/dispatch/dispatchinformationprovider.hxx +++ b/framework/inc/dispatch/dispatchinformationprovider.hxx @@ -20,7 +20,6 @@ #ifndef INCLUDED_FRAMEWORK_INC_DISPATCH_DISPATCHINFORMATIONPROVIDER_HXX #define INCLUDED_FRAMEWORK_INC_DISPATCH_DISPATCHINFORMATIONPROVIDER_HXX -#include <threadhelp/threadhelpbase.hxx> #include <macros/generic.hxx> #include <macros/xinterface.hxx> #include <general.h> @@ -39,8 +38,7 @@ namespace framework{ /*-************************************************************************************************************ @short a helper to merge dispatch information of different sources together. *//*-*************************************************************************************************************/ -class DispatchInformationProvider : private ThreadHelpBase - , public ::cppu::WeakImplHelper1< css::frame::XDispatchInformationProvider > +class DispatchInformationProvider : public ::cppu::WeakImplHelper1< css::frame::XDispatchInformationProvider > { // member diff --git a/framework/source/dispatch/dispatchinformationprovider.cxx b/framework/source/dispatch/dispatchinformationprovider.cxx index 0c7a7494a6b7..dbb45dda40a9 100644 --- a/framework/source/dispatch/dispatchinformationprovider.cxx +++ b/framework/source/dispatch/dispatchinformationprovider.cxx @@ -19,7 +19,6 @@ #include <dispatch/dispatchinformationprovider.hxx> #include <dispatch/closedispatcher.hxx> -#include <threadhelp/guard.hxx> #include <stdtypes.h> #include <services.h> @@ -34,8 +33,7 @@ namespace framework{ DispatchInformationProvider::DispatchInformationProvider(const css::uno::Reference< css::uno::XComponentContext >& xContext , const css::uno::Reference< css::frame::XFrame >& xFrame) - : ThreadHelpBase(&Application::GetSolarMutex()) - , m_xContext (xContext ) + : m_xContext (xContext ) , m_xFrame (xFrame ) { } @@ -130,22 +128,16 @@ css::uno::Sequence< css::frame::DispatchInformation > SAL_CALL DispatchInformati css::uno::Sequence< css::uno::Reference< css::frame::XDispatchInformationProvider > > DispatchInformationProvider::implts_getAllSubProvider() { - // SAFE -> ---------------------------------- - Guard aReadLock(m_aLock); - css::uno::Reference< css::uno::XComponentContext > xContext = m_xContext; - css::uno::Reference< css::frame::XFrame > xFrame(m_xFrame.get(), css::uno::UNO_QUERY); - aReadLock.unlock(); - // <- SAFE ---------------------------------- - + css::uno::Reference< css::frame::XFrame > xFrame(m_xFrame); if (!xFrame.is()) return css::uno::Sequence< css::uno::Reference< css::frame::XDispatchInformationProvider > >(); - CloseDispatcher* pCloser = new CloseDispatcher(xContext, xFrame, OUString("_self")); // explicit "_self" ... not "" ... see implementation of close dispatcher itself! + CloseDispatcher* pCloser = new CloseDispatcher(m_xContext, xFrame, OUString("_self")); // explicit "_self" ... not "" ... see implementation of close dispatcher itself! css::uno::Reference< css::uno::XInterface > xCloser(static_cast< css::frame::XDispatch* >(pCloser), css::uno::UNO_QUERY); css::uno::Reference< css::frame::XDispatchInformationProvider > xCloseDispatch(xCloser , css::uno::UNO_QUERY); css::uno::Reference< css::frame::XDispatchInformationProvider > xController (xFrame->getController() , css::uno::UNO_QUERY); - css::uno::Reference< css::frame::XDispatchInformationProvider > xAppDispatcher = css::frame::AppDispatchProvider::create(xContext); + css::uno::Reference< css::frame::XDispatchInformationProvider > xAppDispatcher = css::frame::AppDispatchProvider::create(m_xContext); css::uno::Sequence< css::uno::Reference< css::frame::XDispatchInformationProvider > > lProvider(3); lProvider[0] = xController ; lProvider[1] = xCloseDispatch; |