summaryrefslogtreecommitdiff
path: root/helpcompiler
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2017-01-26 12:28:58 +0100
committerStephan Bergmann <sbergman@redhat.com>2017-01-26 12:54:43 +0000
commite57ca02849c3d87142ff5ff9099a212e72b8139c (patch)
treebcce66b27261553c308779f3e8663a269ed3a671 /helpcompiler
parent8802ebd5172ec4bc412a59d136c82b77ab452281 (diff)
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'helpcompiler')
-rw-r--r--helpcompiler/inc/HelpCompiler.hxx2
-rw-r--r--helpcompiler/inc/HelpLinker.hxx5
-rw-r--r--helpcompiler/source/HelpCompiler.cxx1
-rw-r--r--helpcompiler/source/HelpLinker.cxx3
4 files changed, 4 insertions, 7 deletions
diff --git a/helpcompiler/inc/HelpCompiler.hxx b/helpcompiler/inc/HelpCompiler.hxx
index c0acdebff90b..e0c1b67823f1 100644
--- a/helpcompiler/inc/HelpCompiler.hxx
+++ b/helpcompiler/inc/HelpCompiler.hxx
@@ -220,7 +220,7 @@ public:
bool in_bExtensionMode);
/// @throws HelpProcessingException
/// @throws BasicCodeTagger::TaggerException
- bool compile() throw (HelpProcessingException, BasicCodeTagger::TaggerException, std::exception);
+ bool compile();
private:
xmlDocPtr getSourceDocument(const fs::path &filePath);
static void tagBasicCodeExamples(xmlDocPtr doc);
diff --git a/helpcompiler/inc/HelpLinker.hxx b/helpcompiler/inc/HelpLinker.hxx
index ddbe3480016b..051a20f04f2f 100644
--- a/helpcompiler/inc/HelpLinker.hxx
+++ b/helpcompiler/inc/HelpLinker.hxx
@@ -51,8 +51,7 @@ public:
void main(std::vector<std::string> &args,
std::string* pExtensionPath = nullptr,
std::string* pDestination = nullptr,
- const OUString* pOfficeHelpPath = nullptr )
- throw( HelpProcessingException, std::exception );
+ const OUString* pOfficeHelpPath = nullptr );
HelpLinker()
: bExtensionMode(false)
@@ -85,7 +84,7 @@ private:
void initIndexerPreProcessor();
/// @throws HelpProcessingException
/// @throws BasicCodeTagger::TaggerException
- void link() throw(HelpProcessingException, BasicCodeTagger::TaggerException, std::exception);
+ void link();
static void addBookmark( FILE* pFile_DBHelp, std::string thishid,
const std::string& fileB, const std::string& anchorB,
const std::string& jarfileB, const std::string& titleB );
diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx
index 67dbfcdc8ddb..0eb89533382b 100644
--- a/helpcompiler/source/HelpCompiler.cxx
+++ b/helpcompiler/source/HelpCompiler.cxx
@@ -432,7 +432,6 @@ void myparser::traverse( xmlNodePtr parentNode )
}
bool HelpCompiler::compile()
- throw (HelpProcessingException, BasicCodeTagger::TaggerException, std::exception)
{
// we now have the jaroutputstream, which will contain the document.
// now determine the document as a dom tree in variable docResolved
diff --git a/helpcompiler/source/HelpLinker.cxx b/helpcompiler/source/HelpLinker.cxx
index 1af6a58467a5..243a5fb2f4dc 100644
--- a/helpcompiler/source/HelpLinker.cxx
+++ b/helpcompiler/source/HelpLinker.cxx
@@ -273,7 +273,7 @@ void HelpLinker::initIndexerPreProcessor()
/**
*
*/
-void HelpLinker::link() throw(HelpProcessingException, BasicCodeTagger::TaggerException, std::exception)
+void HelpLinker::link()
{
if( bExtensionMode )
@@ -535,7 +535,6 @@ void HelpLinker::link() throw(HelpProcessingException, BasicCodeTagger::TaggerEx
void HelpLinker::main( std::vector<std::string> &args,
std::string* pExtensionPath, std::string* pDestination,
const OUString* pOfficeHelpPath )
- throw( HelpProcessingException, std::exception )
{
bExtensionMode = false;
helpFiles.clear();