diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-26 13:15:05 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-27 11:15:46 +0200 |
commit | c8fa03b1f565461364b9f6423b65680e09281c14 (patch) | |
tree | 78ff35dfeb569354b41e89b9d55d77b46f7d3d95 /i18nlangtag | |
parent | 82a4ef72d6e34c2f5075069a1b353f7fd41c7595 (diff) |
new loplugin:stringloop, and applied in various
look for OUString being appended to in a loop, better to use
OUStringBuffer to accumulate the results.
Change-Id: Ia36e06e2781a7c546ce9cbad62727aa4c5f10c4b
Reviewed-on: https://gerrit.libreoffice.org/58092
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'i18nlangtag')
-rw-r--r-- | i18nlangtag/source/languagetag/languagetag.cxx | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx b/i18nlangtag/source/languagetag/languagetag.cxx index fd3f1156c744..862b4e24f777 100644 --- a/i18nlangtag/source/languagetag/languagetag.cxx +++ b/i18nlangtag/source/languagetag/languagetag.cxx @@ -1636,10 +1636,10 @@ OUString LanguageTagImpl::getRegionFromLangtag() OUString LanguageTagImpl::getVariantsFromLangtag() { - OUString aVariants; + OUStringBuffer aVariants; synCanonicalize(); if (maBcp47.isEmpty()) - return aVariants; + return OUString(); if (mpImplLangtag) { const lt_list_t* pVariantsT = lt_tag_get_variants( mpImplLangtag); @@ -1651,10 +1651,9 @@ OUString LanguageTagImpl::getVariantsFromLangtag() const char* p = lt_variant_get_tag( pVariantT); if (p) { - if (aVariants.isEmpty()) - aVariants = OUString::createFromAscii( p); - else - aVariants += "-" + OUString::createFromAscii( p); + if (!aVariants.isEmpty()) + aVariants.append("-"); + aVariants.appendAscii(p); } } } @@ -1664,7 +1663,7 @@ OUString LanguageTagImpl::getVariantsFromLangtag() if (mbCachedVariants || cacheSimpleLSCV()) aVariants = maCachedVariants; } - return aVariants; + return aVariants.makeStringAndClear(); } |