diff options
| author | Katarina Behrens <Katarina.Behrens@cib.de> | 2015-08-21 11:53:57 +0200 |
|---|---|---|
| committer | Thorsten Behrens <Thorsten.Behrens@CIB.de> | 2015-08-21 22:34:59 +0000 |
| commit | 11b8a74d78e018c67217c05d83bd4947869e535a (patch) | |
| tree | 7a3f4e995e2e7afe6e66e25cc50c6266fbd84c0b /i18npool | |
| parent | 373e71ee65a90daa9a27ff5bb7a3d6c867e4f393 (diff) | |
tdf#93437: Calc RefDialogs were never actually destructed
as ScTabViewShell::CreateRefDialog was still holding VclPtr
reference to them and never released it -- regression from
commit 087f7fe50b03307e2d9202365886e8c37bd7e6e3 which is hereby
reverted.
Now it is *DlgWrapper holding the reference (via
SfxChildWindow::pWindow) and dialogs get properly destructed
when SfxChildWindow dies in SfxViewFrame::SetChildWindow(0, false)
Re tdf#91125, it turns out that the follow-up commit
06ecf7d2aebe64226142ee27c2512351960f8bb1 is actually enough to
prevent the crash.
Change-Id: I895825da59aabc7c0de530ecb528b9bf5acde562
Reviewed-on: https://gerrit.libreoffice.org/17899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Diffstat (limited to 'i18npool')
0 files changed, 0 insertions, 0 deletions