diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2023-04-27 22:19:44 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2023-04-28 08:14:11 +0200 |
| commit | 2eb3922750b385dcadfd124d7baf686cec40eb5e (patch) | |
| tree | 6289f1d6be2ab6a6cae60c2216f180803da91ee9 /i18npool | |
| parent | 21fad629e72791f6cc1791fdba858bf52b9bfeff (diff) | |
Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* impls
Ever since 95823ae83c8c13c5c10c5084e2a90549ff2eb25e "#95565#add new phonetic
entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric first)" was using the same implementation as
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric last)" was using the same implementation as
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped
by syllable)". But there appears to be no evidence that those implementation
names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"
and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" are
actually used anywhere (see also c9b6bf655e6de50c55629b4805399932c90a3b30 "Add
some tests for (Japanese) i18n::IndexEntrySupplier behavior").
And a problem with the current setup is that instantiation those two
implementation names will return implementations whose getImplementationName()
does not match those implementation names (but rather returns
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric last) (grouped by syllable)", resp.)---which is something that
would create failures with an improved CppunitTest_services.
Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'i18npool')
| -rw-r--r-- | i18npool/util/i18npool.component | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/i18npool/util/i18npool.component b/i18npool/util/i18npool.component index e706425d6fcd..2f5085f02384 100644 --- a/i18npool/util/i18npool.component +++ b/i18npool/util/i18npool.component @@ -120,10 +120,6 @@ constructor="i18npool_IndexEntrySupplier_asian_get_implementation"> <service name="com.sun.star.i18n.IndexEntrySupplier_asian"/> </implementation> - <implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" - constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_syllable_get_implementation"> - <service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"/> - </implementation> <implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant)" constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_consonant_get_implementation"> <service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant)"/> @@ -132,10 +128,6 @@ constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_syllable_get_implementation"> <service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)"/> </implementation> - <implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" - constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_last_by_syllable_get_implementation"> - <service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)"/> - </implementation> <implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by consonant)" constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_last_by_consonant_get_implementation"> <service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by consonant)"/> |