Find places where OUString and OString are passed by value.

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

2 files changed, 2 insertions, 2 deletions

diff --git a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
index e58afe75efc0..8a110c040a51 100644
--- a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
+++ b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
@@ -521,7 +521,7 @@ void lcl_formatCharsGR(const sal_Unicode table[], int n, OUString& s )
 }
 
 static
-bool should_ignore( OUString s )
+bool should_ignore( const OUString& s )
 {
         // return true if blank or null
         return s == " " || (!s.isEmpty() && s[0]==0);
diff --git a/i18npool/source/localedata/localedata.cxx b/i18npool/source/localedata/localedata.cxx
index b9748c7472f1..a45bab178575 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -1383,7 +1383,7 @@ public:
     virtual sal_Bool SAL_CALL hasElements(  ) throw(RuntimeException, std::exception);
 };
 
-static sal_Char* U2C( OUString str )
+static sal_Char* U2C( const OUString& str )
 {
     sal_Char* s = new sal_Char[ str.getLength()+1 ];
     int i;