diff options
author | Justin Luth <justin.luth@collabora.com> | 2019-06-15 22:15:32 +0300 |
---|---|---|
committer | Justin Luth <justin_luth@sil.org> | 2019-06-27 06:09:43 +0200 |
commit | d35171456bc230efdaa9426da1398b2db7fa0df8 (patch) | |
tree | d2d6956c06a9b64c227d55aa423feaab8175e2bf /icon-themes/breeze_svg/res/base128.svg | |
parent | ae823e4633a76d13cebc6432b9e44b9b2862326b (diff) |
tdf#125609c10 vcl/button: enforce only one radio selected on init
This patch does not solve the main LO 6.2 problem in bug 125609,
but fixes the related problem from comments 10/11.
This patch fixes two different scenarios:
1.) Sometimes buttons could fall through the other safety nets and
have multiple radio buttons selected in a single group at display time.
Since ImplInitStyle can be called multiple times for the same
button, ensure that once everything is imported (IsRadioCheckEnabled)
that any calls to this double-check that only one button is enabled.
First come, first served if by programmer error multiple are marked as
IsChecked in the same group. This problem existed pre-LO 6.2,
so it had nothing to do with tabstops specifically.
2.) This patch specifically fixes the 6.2 regression with the
Grammalecte extension Graphic Options dialog box. In this case
Dialog::GrabFocusToFirstControl ended up being treated as a "click"
on a tabstopped, unchecked radio, because setting the state
never called the SetState/Checked function, but only the Init,
and so the uncheckAllOther function never removed any tabstops.
Change-Id: I98272d6c81cf582a15c2e6bf04e6ed60da1d9c71
Reviewed-on: https://gerrit.libreoffice.org/74108
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'icon-themes/breeze_svg/res/base128.svg')
0 files changed, 0 insertions, 0 deletions