diff options
author | Mike Kaganski <mike.kaganski@collabora.com> | 2025-01-23 22:07:29 +0500 |
---|---|---|
committer | Mike Kaganski <mike.kaganski@collabora.com> | 2025-01-23 20:14:51 +0100 |
commit | f071292a5af10f4718302a1bf9cc9cdc37528225 (patch) | |
tree | d09a372b32a19f7cde036d32a29887aab7d36382 /icon-themes/sifr/cmd/sc_freezepanes.png | |
parent | 63e7a70ad1a6a8ec4190ab510f683d2fc9dea417 (diff) |
tdf#160578: do not modify procedure argument type based on its use
HEADmaster
Since the initial import, there is a code in SbiExpression::Term, that
checks if the defined symbol is used as object (e.g., dot notation to
access its members), and then, if its defined type is Variant, then it
is corrected to Object. There is no rationale for this in comments; so
I have no way to know what could break if that core is dropped.
It's obvious that at least for procedure arguments, such correction is
wrong: the argument definition is the procedure's API; and the actual
use of the symbol should not unexpectedly change what is advertised.
This change limits the application of the correction to non-arguments.
If it should be dropped completely is a separate question.
Change-Id: Ia902afa3f744d0d51510ba6903be45f78e2f6429
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180665
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'icon-themes/sifr/cmd/sc_freezepanes.png')
0 files changed, 0 insertions, 0 deletions