diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 09:13:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 13:26:27 +0100 |
| commit | be8c414567f49242164b1fdfb12764b16be355c1 (patch) | |
| tree | c1f505272ec27e5e069f5d6964dc4f7b20150a5a /idl/source | |
| parent | be94207ecb88a9005ee6624e354d70c9613d7653 (diff) | |
loplugin:unusedmethods also check for functions returning bool
we were previously excluding them
Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'idl/source')
| -rw-r--r-- | idl/source/objects/bastype.cxx | 5 | ||||
| -rw-r--r-- | idl/source/prj/parser.cxx | 7 |
2 files changed, 5 insertions, 7 deletions
diff --git a/idl/source/objects/bastype.cxx b/idl/source/objects/bastype.cxx index 5a34b1c381ea..0dddd98d5323 100644 --- a/idl/source/objects/bastype.cxx +++ b/idl/source/objects/bastype.cxx @@ -49,7 +49,7 @@ bool SvBOOL::ReadSvIdl( SvStringHashEntry const * pName, SvTokenStream & rInStm return false; } -bool SvIdentifier::ReadSvIdl( SvStringHashEntry const * pName, SvTokenStream & rInStm ) +void SvIdentifier::ReadSvIdl( SvStringHashEntry const * pName, SvTokenStream & rInStm ) { sal_uInt32 nTokPos = rInStm.Tell(); SvToken& rTok = rInStm.GetToken_Next(); @@ -70,10 +70,9 @@ bool SvIdentifier::ReadSvIdl( SvStringHashEntry const * pName, SvTokenStream & r bOk = rInStm.ReadIf( ')' ); } if( bOk ) - return true; + return; } rInStm.Seek( nTokPos ); - return false; } void SvIdentifier::ReadSvIdl( SvIdlDataBase & rBase, diff --git a/idl/source/prj/parser.cxx b/idl/source/prj/parser.cxx index 5701f4f93cd0..c6fa85431f0e 100644 --- a/idl/source/prj/parser.cxx +++ b/idl/source/prj/parser.cxx @@ -499,7 +499,7 @@ bool SvIdlParser::ReadIfBoolAttribute( SvBOOL& rBool, SvStringHashEntry const * return false; } -bool SvIdlParser::ReadIfIdAttribute( SvIdentifier& rIdentifier, SvStringHashEntry const * pName ) +void SvIdlParser::ReadIfIdAttribute( SvIdentifier& rIdentifier, SvStringHashEntry const * pName ) { sal_uInt32 nTokPos = rInStm.Tell(); SvToken& rTok = rInStm.GetToken_Next(); @@ -514,10 +514,9 @@ bool SvIdlParser::ReadIfIdAttribute( SvIdentifier& rIdentifier, SvStringHashEntr rIdentifier.setString(rTok.GetString()); rInStm.GetToken_Next(); } - return true; } - rInStm.Seek( nTokPos ); - return false; + else + rInStm.Seek( nTokPos ); } void SvIdlParser::ReadDelimiter() |