diff options
author | Gabriel Masei <gabriel.masei@1and1.ro> | 2020-09-02 19:22:23 +0300 |
---|---|---|
committer | Jan Holesovsky <kendy@collabora.com> | 2020-09-21 14:39:17 +0200 |
commit | 137440e161f0f8631e7e67ba0609680d6686fa94 (patch) | |
tree | 8a91ebb7f9d559ebdd891abfe798f94952a67109 /idlc/source | |
parent | 859596233146590f7ebac1f05bbb83ce5ea8aac4 (diff) |
lok: remove .uno:ModifiedStatus message from deduplication mechanism
This fixes the following issue in Online:
When a save is performed while a cell is still edited the save icon
does not reflect the correct state of the document: it shows that
the document is dirty although it is not. This is generated by two facts:
1. The status cache is avoided when sending the -dirty- status right
after the cell editing is finished. Because the cache has an old value
of -false- for ModifiedStatus, the notification that is sent after saving,
with -false- value, is ignored. We should not avoid the status cache.
2. Because there is a mechanism that keeps only the last notification
value for a status change in the queue that keeps messages that were not
sent yet (deduplication), the .uno:ModifiedStatus message with a value of -true-
that is enqueued right after the cell edit is finished is replaced by the same
message with a value of -false- that is enqueued after the save is finished.
This happens if the flush mechanism doesn't occur between them.
Change-Id: I3348bf230ba53a154c29e7d8ab064df7694adeae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101948
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'idlc/source')
0 files changed, 0 insertions, 0 deletions