diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-05-13 10:51:04 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-05-13 10:51:04 +0200 |
| commit | 0c493207723516586882e53c532dc977a1deec32 (patch) | |
| tree | 3b6df1a25ed1623057bcf479638bf2ee22ca7cba /idlc | |
| parent | 96b129052e280e094b6a150b185f9e8285cecca4 (diff) | |
Revert "CID#705985 ensure umask for mkstemp"
This reverts commit 5f5a981dd6df406b7bbddd88fa0b701b5a8d2246. Coverity warning
about mkstemp without umask appears to be bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?) and calling umask is not
MT-safe, see fdo#60338 "FILESAVE: Saved files have incorrect permissions on
linux."
Diffstat (limited to 'idlc')
| -rw-r--r-- | idlc/source/idlccompile.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/idlc/source/idlccompile.cxx b/idlc/source/idlccompile.cxx index bbd080f550ca..c88cac79db4a 100644 --- a/idlc/source/idlccompile.cxx +++ b/idlc/source/idlccompile.cxx @@ -38,8 +38,6 @@ #else #include <wait.h> #endif -#include <sys/types.h> -#include <sys/stat.h> #endif #include <string.h> @@ -156,9 +154,7 @@ OString makeTempName(const OString& prefix) strncat(tmpFilePattern, "XXXXXX", sizeof(tmpFilePattern)-1-strlen(tmpFilePattern)); #ifdef SAL_UNX - mode_t nOrigMode = umask(S_IRWXG | S_IRWXO); int nDescriptor = mkstemp(tmpFilePattern); - umask(nOrigMode); if( -1 == nDescriptor ) { fprintf(stderr, "idlc: mkstemp(\"%s\") failed: %s\n", tmpFilePattern, strerror(errno)); |