diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-02-21 07:26:06 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-02-21 14:50:28 +0100 |
| commit | 9ad252b2e79576119c2d733a1a45fdd9e9f83140 (patch) | |
| tree | 87fee16145d457b6799a05c389d85270476f7f35 /idlc | |
| parent | 3aca35f1505fa552eaa316a2d47a60ef52646525 (diff) | |
Drop o3tl::optional wrapper
...now that macOS builds are guaranteed to have std::optional since
358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to
Xcode 11.3 and macOS 10.14.4".
The change is done mostly mechanically with
> for i in $(git grep -Fl optional); do
> sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \
> -e 's/\<o3tl::optional\>/std::optional/g' \
> -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i"
> done
> for i in $(git grep -Flw o3tl::nullopt); do
> sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i"
> done
(though that causes some of the resulting
#include <optional>
to appear at different places relative to other includes than if they had been
added manually), plus a few manual modifications:
* adapt bin/find-unneeded-includes
* adapt desktop/IwyuFilter_desktop.yaml
* remove include/o3tl/optional.hxx
* quote resulting "<"/">" as "<"/">" in officecfg/registry/cppheader.xsl
* and then solenv/clang-format/reformat-formatted-files
Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'idlc')
| -rw-r--r-- | idlc/inc/astexpression.hxx | 4 | ||||
| -rw-r--r-- | idlc/inc/astsequence.hxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/idlc/inc/astexpression.hxx b/idlc/inc/astexpression.hxx index b146e9c85a07..05d20baa51cd 100644 --- a/idlc/inc/astexpression.hxx +++ b/idlc/inc/astexpression.hxx @@ -24,7 +24,7 @@ #include <memory> #include "idlc.hxx" -#include <o3tl/optional.hxx> +#include <optional> // Enum to define all the different operators to combine expressions enum class ExprComb @@ -130,7 +130,7 @@ private: m_subExpr2; std::unique_ptr<AstExprValue> m_exprValue; - o3tl::optional<OString> + std::optional<OString> m_xSymbolicName; }; diff --git a/idlc/inc/astsequence.hxx b/idlc/inc/astsequence.hxx index 68a98dfe5162..41024894f47a 100644 --- a/idlc/inc/astsequence.hxx +++ b/idlc/inc/astsequence.hxx @@ -38,7 +38,7 @@ public: virtual const char* getRelativName() const override; private: AstType const * m_pMemberType; - mutable o3tl::optional<OString> m_xRelativName; + mutable std::optional<OString> m_xRelativName; }; #endif // INCLUDED_IDLC_INC_ASTSEQUENCE_HXX |