diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:09:01 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:19:22 +0200 |
commit | 91dd2db17bd6cb9b357d1d69b187174e31eabef0 (patch) | |
tree | d634de3a1a6820904b5699c2136b79b1a5a807c7 /idlc | |
parent | 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef (diff) |
loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
Diffstat (limited to 'idlc')
-rw-r--r-- | idlc/inc/astattribute.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astbasetype.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astconstant.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astconstants.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astenum.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astexception.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astinterface.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astinterfacemember.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astmember.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astmodule.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astneeds.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astobserves.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astoperation.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astparameter.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astsequence.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astservice.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/astservicemember.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/aststruct.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/asttype.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/asttypedef.hxx | 2 |
20 files changed, 20 insertions, 20 deletions
diff --git a/idlc/inc/astattribute.hxx b/idlc/inc/astattribute.hxx index 2d88b47e4082..e4bbd517318f 100644 --- a/idlc/inc/astattribute.hxx +++ b/idlc/inc/astattribute.hxx @@ -41,7 +41,7 @@ public: , m_flags(flags) , m_pType(pType) {} - virtual ~AstAttribute() {} + virtual ~AstAttribute() override {} void setExceptions( OUString const * getDoc, DeclList const * getExc, diff --git a/idlc/inc/astbasetype.hxx b/idlc/inc/astbasetype.hxx index a7edf3d817b0..35d0cc1276d0 100644 --- a/idlc/inc/astbasetype.hxx +++ b/idlc/inc/astbasetype.hxx @@ -31,7 +31,7 @@ public: , m_exprType(type) {} - virtual ~AstBaseType() {} + virtual ~AstBaseType() override {} virtual bool isUnsigned() const override { switch (m_exprType) { diff --git a/idlc/inc/astconstant.hxx b/idlc/inc/astconstant.hxx index 7453c47954b3..e092b7340ee1 100644 --- a/idlc/inc/astconstant.hxx +++ b/idlc/inc/astconstant.hxx @@ -31,7 +31,7 @@ public: AstExpression* pExpr, const OString& name, AstScope* pScope); AstConstant(const ExprType type, AstExpression* pExpr, const OString& name, AstScope* pScope); - virtual ~AstConstant(); + virtual ~AstConstant() override; AstExpression* getConstValue() { return m_pConstValue; } diff --git a/idlc/inc/astconstants.hxx b/idlc/inc/astconstants.hxx index f3f7f3bed2d1..fb990f92dda8 100644 --- a/idlc/inc/astconstants.hxx +++ b/idlc/inc/astconstants.hxx @@ -27,7 +27,7 @@ public: AstConstants(const OString& name, AstScope* pScope) : AstModule(NT_constants, name, pScope) {} - virtual ~AstConstants() {} + virtual ~AstConstants() override {} }; #endif // INCLUDED_IDLC_INC_ASTCONSTANTS_HXX diff --git a/idlc/inc/astenum.hxx b/idlc/inc/astenum.hxx index d7c8977fb932..6d6324353ce3 100644 --- a/idlc/inc/astenum.hxx +++ b/idlc/inc/astenum.hxx @@ -29,7 +29,7 @@ class AstEnum : public AstType public: AstEnum(const OString& name, AstScope* pScope); - virtual ~AstEnum(); + virtual ~AstEnum() override; sal_Int32 getEnumValueCount() { return m_enumValueCount++; } diff --git a/idlc/inc/astexception.hxx b/idlc/inc/astexception.hxx index 64790c694048..e00e28895b11 100644 --- a/idlc/inc/astexception.hxx +++ b/idlc/inc/astexception.hxx @@ -28,7 +28,7 @@ public: : AstStruct(NT_exception, name, pBaseType, pScope) {} - virtual ~AstException() {} + virtual ~AstException() override {} }; #endif // INCLUDED_IDLC_INC_ASTEXCEPTION_HXX diff --git a/idlc/inc/astinterface.hxx b/idlc/inc/astinterface.hxx index caabbe669f11..1f789a304b35 100644 --- a/idlc/inc/astinterface.hxx +++ b/idlc/inc/astinterface.hxx @@ -49,7 +49,7 @@ public: AstInterface( const OString& name, AstInterface const * pInherits, AstScope* pScope); - virtual ~AstInterface(); + virtual ~AstInterface() override; InheritedInterfaces const & getAllInheritedInterfaces() const { return m_inheritedInterfaces; } diff --git a/idlc/inc/astinterfacemember.hxx b/idlc/inc/astinterfacemember.hxx index 1740d3518085..a627b0d91bfe 100644 --- a/idlc/inc/astinterfacemember.hxx +++ b/idlc/inc/astinterfacemember.hxx @@ -30,7 +30,7 @@ public: , m_flags(flags) , m_pRealInterface(pRealInterface) {} - virtual ~AstInterfaceMember() {} + virtual ~AstInterfaceMember() override {} AstInterface* getRealInterface() { return m_pRealInterface; } diff --git a/idlc/inc/astmember.hxx b/idlc/inc/astmember.hxx index d01dbde7922c..0563eb8c7971 100644 --- a/idlc/inc/astmember.hxx +++ b/idlc/inc/astmember.hxx @@ -31,7 +31,7 @@ public: AstType const * pType, OString const & name, AstScope * pScope): AstDeclaration(NT_member, name, pScope), m_pType(pType) {} - virtual ~AstMember() {} + virtual ~AstMember() override {} AstType const * getType() const { return m_pType; } diff --git a/idlc/inc/astmodule.hxx b/idlc/inc/astmodule.hxx index 770c11a856a9..6f41b2d7cabe 100644 --- a/idlc/inc/astmodule.hxx +++ b/idlc/inc/astmodule.hxx @@ -34,7 +34,7 @@ public: : AstDeclaration(type, name, pScope) , AstScope(type) {} - virtual ~AstModule() {} + virtual ~AstModule() override {} virtual bool dump(RegistryKey& rKey) override; }; diff --git a/idlc/inc/astneeds.hxx b/idlc/inc/astneeds.hxx index 6674e2804695..0df77f2edd01 100644 --- a/idlc/inc/astneeds.hxx +++ b/idlc/inc/astneeds.hxx @@ -28,7 +28,7 @@ public: : AstDeclaration(NT_needs, name, pScope) , m_pRealService(pRealService) {} - virtual ~AstNeeds() {} + virtual ~AstNeeds() override {} AstService* getRealService() { return m_pRealService; } diff --git a/idlc/inc/astobserves.hxx b/idlc/inc/astobserves.hxx index c7760096a095..8e4c404eb122 100644 --- a/idlc/inc/astobserves.hxx +++ b/idlc/inc/astobserves.hxx @@ -28,7 +28,7 @@ public: : AstDeclaration(NT_observes, name, pScope) , m_pRealInterface(pRealInterface) {} - virtual ~AstObserves() {} + virtual ~AstObserves() override {} AstInterface* getRealInterface() { return m_pRealInterface; } diff --git a/idlc/inc/astoperation.hxx b/idlc/inc/astoperation.hxx index 5a5194f92605..85b12c8321d0 100644 --- a/idlc/inc/astoperation.hxx +++ b/idlc/inc/astoperation.hxx @@ -35,7 +35,7 @@ public: , AstScope(NT_operation) , m_pReturnType(pReturnType) {} - virtual ~AstOperation() {} + virtual ~AstOperation() override {} bool isVariadic() const; diff --git a/idlc/inc/astparameter.hxx b/idlc/inc/astparameter.hxx index 250aeaed33f5..ba7933c0ea09 100644 --- a/idlc/inc/astparameter.hxx +++ b/idlc/inc/astparameter.hxx @@ -32,7 +32,7 @@ public: AstMember(NT_parameter, type, name, scope), m_direction(direction), m_rest(rest) {} - virtual ~AstParameter() {} + virtual ~AstParameter() override {} Direction getDirection() const { return m_direction; } diff --git a/idlc/inc/astsequence.hxx b/idlc/inc/astsequence.hxx index bdc132872455..aa800ca9e052 100644 --- a/idlc/inc/astsequence.hxx +++ b/idlc/inc/astsequence.hxx @@ -29,7 +29,7 @@ public: , m_pMemberType(pMemberType) , m_pRelativName(nullptr) {} - virtual ~AstSequence() + virtual ~AstSequence() override { if ( m_pRelativName ) delete m_pRelativName; diff --git a/idlc/inc/astservice.hxx b/idlc/inc/astservice.hxx index 400e7c6f2313..8a7c0cf7edd5 100644 --- a/idlc/inc/astservice.hxx +++ b/idlc/inc/astservice.hxx @@ -38,7 +38,7 @@ public: , m_singleInterfaceBasedService(false) , m_defaultConstructor(false) {} - virtual ~AstService() {} + virtual ~AstService() override {} virtual bool dump(RegistryKey& rKey) override; diff --git a/idlc/inc/astservicemember.hxx b/idlc/inc/astservicemember.hxx index 13cd97298bf7..eba1cd95aa45 100644 --- a/idlc/inc/astservicemember.hxx +++ b/idlc/inc/astservicemember.hxx @@ -30,7 +30,7 @@ public: , m_flags(flags) , m_pRealService(pRealService) {} - virtual ~AstServiceMember() {} + virtual ~AstServiceMember() override {} AstService* getRealService() { return m_pRealService; } diff --git a/idlc/inc/aststruct.hxx b/idlc/inc/aststruct.hxx index 280f23165d43..083cd30018f1 100644 --- a/idlc/inc/aststruct.hxx +++ b/idlc/inc/aststruct.hxx @@ -38,7 +38,7 @@ public: const OString& name, AstStruct const* pBaseType, AstScope* pScope); - virtual ~AstStruct(); + virtual ~AstStruct() override; DeclList::size_type getTypeParameterCount() const { return m_typeParameters.size(); } diff --git a/idlc/inc/asttype.hxx b/idlc/inc/asttype.hxx index 67f8d4d075ee..083bd3b42184 100644 --- a/idlc/inc/asttype.hxx +++ b/idlc/inc/asttype.hxx @@ -28,7 +28,7 @@ public: : AstDeclaration(type, name, pScope) {} - virtual ~AstType() {} + virtual ~AstType() override {} virtual bool isUnsigned() const { return false; } }; diff --git a/idlc/inc/asttypedef.hxx b/idlc/inc/asttypedef.hxx index 2f9017200592..64eb14848d71 100644 --- a/idlc/inc/asttypedef.hxx +++ b/idlc/inc/asttypedef.hxx @@ -28,7 +28,7 @@ public: AstType const * baseType, OString const & name, AstScope * scope): AstType(NT_typedef, name, scope), m_pBaseType(baseType) {} - virtual ~AstTypeDef() {} + virtual ~AstTypeDef() override {} AstType const * getBaseType() const { return m_pBaseType; } |