diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 09:13:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 13:26:27 +0100 |
| commit | be8c414567f49242164b1fdfb12764b16be355c1 (patch) | |
| tree | c1f505272ec27e5e069f5d6964dc4f7b20150a5a /idlc | |
| parent | be94207ecb88a9005ee6624e354d70c9613d7653 (diff) | |
loplugin:unusedmethods also check for functions returning bool
we were previously excluding them
Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'idlc')
| -rw-r--r-- | idlc/inc/astattribute.hxx | 2 | ||||
| -rw-r--r-- | idlc/inc/astoperation.hxx | 2 | ||||
| -rw-r--r-- | idlc/source/astdump.cxx | 4 | ||||
| -rw-r--r-- | idlc/source/astoperation.cxx | 4 |
4 files changed, 4 insertions, 8 deletions
diff --git a/idlc/inc/astattribute.hxx b/idlc/inc/astattribute.hxx index 034a3a40d847..7ce370a7fa94 100644 --- a/idlc/inc/astattribute.hxx +++ b/idlc/inc/astattribute.hxx @@ -85,7 +85,7 @@ public: bool isRemoveable() const { return ((m_flags & AF_REMOVABLE) == AF_REMOVABLE); } - bool dumpBlob( + void dumpBlob( typereg::Writer & rBlob, sal_uInt16 index, sal_uInt16 * methodIndex) const; private: diff --git a/idlc/inc/astoperation.hxx b/idlc/inc/astoperation.hxx index ced2fb32213a..a6aa2cffde1a 100644 --- a/idlc/inc/astoperation.hxx +++ b/idlc/inc/astoperation.hxx @@ -42,7 +42,7 @@ public: void setExceptions(DeclList const * pExceptions); - bool dumpBlob(typereg::Writer & rBlob, sal_uInt16 index); + void dumpBlob(typereg::Writer & rBlob, sal_uInt16 index); private: AstType const * m_pReturnType; diff --git a/idlc/source/astdump.cxx b/idlc/source/astdump.cxx index 7b869b7564dc..fbdd7232d893 100644 --- a/idlc/source/astdump.cxx +++ b/idlc/source/astdump.cxx @@ -321,7 +321,7 @@ bool AstService::dump(RegistryKey& rKey) return true; } -bool AstAttribute::dumpBlob( +void AstAttribute::dumpBlob( typereg::Writer & rBlob, sal_uInt16 index, sal_uInt16 * methodIndex) const { RTFieldAccess accessMode = RTFieldAccess::INVALID; @@ -377,8 +377,6 @@ bool AstAttribute::dumpBlob( dumpExceptions( rBlob, m_setDocumentation, m_setExceptions, RTMethodMode::ATTRIBUTE_SET, methodIndex); - - return true; } void AstAttribute::dumpExceptions( diff --git a/idlc/source/astoperation.cxx b/idlc/source/astoperation.cxx index 2ff452690077..122b4a57992f 100644 --- a/idlc/source/astoperation.cxx +++ b/idlc/source/astoperation.cxx @@ -38,7 +38,7 @@ bool AstOperation::isVariadic() const { && static_cast< AstParameter const * >(*(--i))->isRest(); } -bool AstOperation::dumpBlob(typereg::Writer & rBlob, sal_uInt16 index) +void AstOperation::dumpBlob(typereg::Writer & rBlob, sal_uInt16 index) { sal_uInt16 nParam = getNodeCount(NT_parameter); sal_uInt16 nExcep = static_cast<sal_uInt16>(m_exceptions.size()); @@ -113,8 +113,6 @@ bool AstOperation::dumpBlob(typereg::Writer & rBlob, sal_uInt16 index) ++iter; } } - - return true; } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |