diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /include/basic | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/basic')
| -rw-r--r-- | include/basic/basmgr.hxx | 8 | ||||
| -rw-r--r-- | include/basic/codecompletecache.hxx | 4 | ||||
| -rw-r--r-- | include/basic/sbstar.hxx | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/include/basic/basmgr.hxx b/include/basic/basmgr.hxx index 64e4ac597df7..b439baed85fa 100644 --- a/include/basic/basmgr.hxx +++ b/include/basic/basmgr.hxx @@ -147,8 +147,8 @@ public: sal_uInt16 GetLibCount() const; StarBASIC* GetLib( sal_uInt16 nLib ) const; - StarBASIC* GetLib( const OUString& rName ) const; - sal_uInt16 GetLibId( const OUString& rName ) const; + StarBASIC* GetLib( std::u16string_view rName ) const; + sal_uInt16 GetLibId( std::u16string_view rName ) const; OUString GetLibName( sal_uInt16 nLib ); @@ -188,7 +188,7 @@ public: takes the names of modules whose size exceeds the legacy limit */ bool LegacyPsswdBinaryLimitExceeded( std::vector< OUString >& _out_rModuleNames ); - bool HasExeCode( const OUString& ); + bool HasExeCode( std::u16string_view ); /// determines whether the Basic Manager has a given macro, given by fully qualified name bool HasMacro( OUString const& i_fullyQualifiedName ) const; /// executes a given macro @@ -202,7 +202,7 @@ private: BASIC_DLLPRIVATE StarBASIC* GetStdLib() const; BASIC_DLLPRIVATE StarBASIC* AddLib( SotStorage& rStorage, const OUString& rLibName, bool bReference ); BASIC_DLLPRIVATE void RemoveLib( sal_uInt16 nLib ); - BASIC_DLLPRIVATE bool HasLib( const OUString& rName ) const; + BASIC_DLLPRIVATE bool HasLib( std::u16string_view rName ) const; BASIC_DLLPRIVATE StarBASIC* CreateLibForLibContainer( const OUString& rLibName, const css::uno::Reference< css::script::XLibraryContainer >& xScriptCont ); diff --git a/include/basic/codecompletecache.hxx b/include/basic/codecompletecache.hxx index 37ab4a499a16..2c6c0873fcb0 100644 --- a/include/basic/codecompletecache.hxx +++ b/include/basic/codecompletecache.hxx @@ -83,8 +83,8 @@ public: void InsertGlobalVar( const OUString& sVarName, const OUString& sVarType ); void InsertLocalVar( const OUString& sProcName, const OUString& sVarName, const OUString& sVarType ); - OUString GetVarType( const OUString& sVarName ) const; - OUString GetCorrectCaseVarName( const OUString& sVarName, const OUString& sActProcName ) const; + OUString GetVarType( std::u16string_view sVarName ) const; + OUString GetCorrectCaseVarName( std::u16string_view sVarName, std::u16string_view sActProcName ) const; void Clear(); }; diff --git a/include/basic/sbstar.hxx b/include/basic/sbstar.hxx index 7ff6a138123e..bdcf167edd49 100644 --- a/include/basic/sbstar.hxx +++ b/include/basic/sbstar.hxx @@ -107,7 +107,7 @@ public: SbModules& GetModules() { return pModules; } SbxObject* GetRtl() { return pRtl.get(); } - SbModule* FindModule( const OUString& ); + SbModule* FindModule( std::u16string_view ); // Run init code of all modules (including the inserted Doc-Basics) void InitAllModules( StarBASIC const * pBasicNotToInit = nullptr ); void DeInitAllModules(); |