new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

1 files changed, 2 insertions, 2 deletions

diff --git a/include/codemaker/exceptiontree.hxx b/include/codemaker/exceptiontree.hxx
index ab395c68be17..2e4795c5f020 100644
--- a/include/codemaker/exceptiontree.hxx
+++ b/include/codemaker/exceptiontree.hxx
@@ -100,11 +100,11 @@ public:
     /**
        Gives access to the resultant exception hierarchy.
 
-       @return a non-null pointer to the root of the exception hierarchy, as
+       @return a reference to the root of the exception hierarchy, as
        formed by all previous calls to add; it is an error if any calls to add
        follow the first call to getRoot
      */
-    ExceptionTreeNode const * getRoot() const { return &m_root; }
+    ExceptionTreeNode const & getRoot() const { return m_root; }
 
 private:
     ExceptionTree(ExceptionTree &); // not implemented