diff options
author | Justin Luth <justin.luth@collabora.com> | 2024-11-21 15:08:45 -0500 |
---|---|---|
committer | Justin Luth <justin.luth@collabora.com> | 2024-11-22 04:52:46 +0100 |
commit | 0d3748e5fbfb2ac8dd60d491d566075938927237 (patch) | |
tree | f5762b6b9b99c65ceaadb9324ef601b9ca0c11b7 /include/cppcanvas/sprite.hxx | |
parent | d3613d15e518c0c8cc4930c4bdf37219813fd665 (diff) |
tdf#163598 editeng: avoid using fake outline depth
Most implementations do not actually
do anything meaningful with Get/SetDepth,
so don't exception or accept their values.
To fix the bug, I could have just checked for
dynamic_cast<SvxEditEngineForwarder*>
(since it supports EE_PARA_OUTLLEVEL directly)
but this way seemed more encompassing.
The potential downside is that EE_PARA_OUTLLEVEL
will be requested as a real property
after GetPropertyValueHelper
with some of these dummy providers,
and who knows what UNO might do about that...
IF this patch causes problems,
then I need to implement Get/SetDepth
in SvxEditEngineForwarder
(or consider the dummy providers as SupportsOutlineDepth).
Change-Id: I74bf5e39a13bb1d588c39634347eb0982bda66b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176981
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Diffstat (limited to 'include/cppcanvas/sprite.hxx')
0 files changed, 0 insertions, 0 deletions