diff options
| author | Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> | 2023-12-21 15:02:52 +0100 |
|---|---|---|
| committer | Armin Le Grand <Armin.Le.Grand@me.com> | 2023-12-21 19:21:46 +0100 |
| commit | 71c555c5ae31d84dff8d9448fd2be4dab23f20a8 (patch) | |
| tree | 6f45dda2443a4a41ffd478e494ae459fa3f6ffd3 /include/drawinglayer | |
| parent | 90277a87b13074c82e2e9aa08befc08c235087f3 (diff) | |
Add flush mechanism to buffered Primitives II
As sberg mentioned in previous change this might be responsible
for heap-use-after-free problems. I took a look and it seems
to be possible that the timer calls back while deletion of the
helper is in progress, so I try now to first stop the timer
and then delete so that it cannot trigger. Will see if that
works - if not I might have to use another lock...
Change-Id: I1ae27d9ed890f352904cab18c3292b449659a3ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161128
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Diffstat (limited to 'include/drawinglayer')
| -rw-r--r-- | include/drawinglayer/primitive2d/BufferedDecompositionGroupPrimitive2D.hxx | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/drawinglayer/primitive2d/BufferedDecompositionGroupPrimitive2D.hxx b/include/drawinglayer/primitive2d/BufferedDecompositionGroupPrimitive2D.hxx index c3bc54e5fca3..031bd360a174 100644 --- a/include/drawinglayer/primitive2d/BufferedDecompositionGroupPrimitive2D.hxx +++ b/include/drawinglayer/primitive2d/BufferedDecompositionGroupPrimitive2D.hxx @@ -65,6 +65,7 @@ protected: public: /// constructor/destructor. For GroupPrimitive2D we need the child parameter, too. BufferedDecompositionGroupPrimitive2D(Primitive2DContainer&& aChildren); + virtual ~BufferedDecompositionGroupPrimitive2D(); /// identical to BufferedDecompositionPrimitive2D, see there please virtual void |