diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2018-07-26 16:42:16 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2018-07-27 08:29:44 +0200 |
commit | 727878a7d8ae25342db75173cc314fa330ccc077 (patch) | |
tree | b70827c83be87059fe553d68ac32c56438af297d /include/editeng/prntitem.hxx | |
parent | 13502c0f201f37960ec06bf1e7e2e8b4d838090a (diff) |
Remove unused copy assignment ops of SfxPoolItem-derived classes
SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy
assignment op. Many derived classes then provide a non-deleted assignment op,
apparently more or less on an as-needed basis. But some of those user-provided
assignment ops are actually unused (and their presence causes
-Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly-
defined---copy ctor of the derived class is used), so remove them. In some
cases that would still cause -Werror=deprected-copy because of a user-declared
dtor, so in those cases explicitly default all the copy/move functions (some of
which will then be implicitly defined as deleted).
Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307
Reviewed-on: https://gerrit.libreoffice.org/58133
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/editeng/prntitem.hxx')
-rw-r--r-- | include/editeng/prntitem.hxx | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/editeng/prntitem.hxx b/include/editeng/prntitem.hxx index 47cd59d0158f..a5d5e9c1fa5a 100644 --- a/include/editeng/prntitem.hxx +++ b/include/editeng/prntitem.hxx @@ -36,7 +36,6 @@ class EDITENG_DLLPUBLIC SvxPrintItem : public SfxBoolItem { public: explicit SvxPrintItem( const sal_uInt16 nId , const bool bPrt = true ); - inline SvxPrintItem &operator=( const SvxPrintItem &rCpy ); // "pure virtual Methods" from SfxPoolItem virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; @@ -51,13 +50,6 @@ inline SvxPrintItem::SvxPrintItem( const sal_uInt16 nId, const bool bPrt ) : SfxBoolItem( nId, bPrt ) {} -inline SvxPrintItem &SvxPrintItem::operator=( const SvxPrintItem &rCpy ) -{ - SetValue( rCpy.GetValue() ); - return *this; -} - - #endif /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |