Remove unused copy assignment ops of SfxPoolItem-derived classes

SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy
assignment op.  Many derived classes then provide a non-deleted assignment op,
apparently more or less on an as-needed basis.  But some of those user-provided
assignment ops are actually unused (and their presence causes
-Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly-
defined---copy ctor of the derived class is used), so remove them.  In some
cases that would still cause -Werror=deprected-copy because of a user-declared
dtor, so in those cases explicitly default all the copy/move functions (some of
which will then be implicitly defined as deleted).

Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307
Reviewed-on: https://gerrit.libreoffice.org/58133
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 5 insertions, 8 deletions

diff --git a/include/editeng/spltitem.hxx b/include/editeng/spltitem.hxx
index 623dca2bfda6..081d8b8ee87a 100644
--- a/include/editeng/spltitem.hxx
+++ b/include/editeng/spltitem.hxx
@@ -39,7 +39,11 @@ public:
 
     inline SvxFormatSplitItem( const bool bSplit /*= true*/,
                             const sal_uInt16 nWh  );
-    inline SvxFormatSplitItem& operator=( const SvxFormatSplitItem& rSplit );
+
+    SvxFormatSplitItem(SvxFormatSplitItem const &) = default;
+    SvxFormatSplitItem(SvxFormatSplitItem &&) = default;
+    SvxFormatSplitItem & operator =(SvxFormatSplitItem const &) = default;
+    SvxFormatSplitItem & operator =(SvxFormatSplitItem &&) = default;
 
     // "pure virtual Methods" from SfxPoolItem
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
@@ -54,13 +58,6 @@ inline SvxFormatSplitItem::SvxFormatSplitItem( const bool bSplit, const sal_uInt
     SfxBoolItem( nWh, bSplit )
 {}
 
-inline SvxFormatSplitItem& SvxFormatSplitItem::operator=(
-    const SvxFormatSplitItem& rSplit )
-{
-    SetValue( rSplit.GetValue() );
-    return *this;
-}
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */