convert SFX_HINT to scoped enum

Notes

(*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a
dynamic_cast check.

(*) In SC, removed the hint id field from ScIndexHint, no point in
storing the hint id twice

(*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no
point in storing two different hint ids

(*) In some cases, multiple #define's used to map to the same SFX_HINT
value (notably the SFX_HINT_USER* values). I made all of those separate
values.

Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5
Reviewed-on: https://gerrit.libreoffice.org/31751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 4 insertions, 7 deletions

diff --git a/include/editeng/unoedhlp.hxx b/include/editeng/unoedhlp.hxx
index ca8dac26fcb0..c08576741cd8 100644
--- a/include/editeng/unoedhlp.hxx
+++ b/include/editeng/unoedhlp.hxx
@@ -30,11 +30,8 @@
 struct EENotify;
 class EditEngine;
 
-#define EDITSOURCE_HINT_PARASMOVED          20
-#define EDITSOURCE_HINT_SELECTIONCHANGED    21
-
 /** Extends TextHint by two additional parameters which are necessary
-    for the EDITSOURCE_HINT_PARASMOVED hint. TextHint's value in this
+    for the SfxHintId::EditSourceParasMoved hint. TextHint's value in this
     case denotes the destination position, the two parameters the
     start and the end of the moved paragraph range.
  */
@@ -45,8 +42,8 @@ private:
     sal_Int32   mnEnd;
 
 public:
-            SvxEditSourceHint( sal_uInt32 nId );
-            SvxEditSourceHint( sal_uInt32 nId, sal_uLong nValue, sal_Int32 nStart, sal_Int32 nEnd );
+            SvxEditSourceHint( SfxHintId nId );
+            SvxEditSourceHint( SfxHintId nId, sal_uLong nValue, sal_Int32 nStart, sal_Int32 nEnd );
 
     using TextHint::GetValue;
     sal_Int32   GetStartValue() const { return mnStart;}
@@ -55,7 +52,7 @@ public:
 class SvxEditSourceHintEndPara :public SvxEditSourceHint
 {
 public:
-    SvxEditSourceHintEndPara() : SvxEditSourceHint(EDITSOURCE_HINT_SELECTIONCHANGED) {}
+    SvxEditSourceHintEndPara() : SvxEditSourceHint(SfxHintId::EditSourceSelectionChanged) {}
 };
 /** Helper class for common functionality in edit sources
  */