new loplugin: countusersofdefaultparams

Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04
Reviewed-on: https://gerrit.libreoffice.org/28353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

11 files changed, 42 insertions, 49 deletions

diff --git a/include/editeng/AccessibleImageBullet.hxx b/include/editeng/AccessibleImageBullet.hxx
index f13908fb23ff..aaa94826b3f9 100644
--- a/include/editeng/AccessibleImageBullet.hxx
+++ b/include/editeng/AccessibleImageBullet.hxx
@@ -145,7 +145,7 @@ namespace accessibility
         sal_Int32 GetParagraphIndex() const { return mnParagraphIndex; }
 
         /// Calls all Listener objects to tell them the change. Don't hold locks when calling this!
-        void FireEvent(const sal_Int16 nEventId, const css::uno::Any& rNewValue = css::uno::Any(), const css::uno::Any& rOldValue = css::uno::Any() ) const;
+        void FireEvent(const sal_Int16 nEventId, const css::uno::Any& rNewValue, const css::uno::Any& rOldValue = css::uno::Any() ) const;
 
     private:
         AccessibleImageBullet( const AccessibleImageBullet& ) = delete;
diff --git a/include/editeng/borderline.hxx b/include/editeng/borderline.hxx
index bd8cb5a0df71..cc0a33f556a5 100644
--- a/include/editeng/borderline.hxx
+++ b/include/editeng/borderline.hxx
@@ -84,7 +84,7 @@ namespace editeng {
         bool            HasGapColor() const { return m_pColorGapFn != nullptr; }
         Color           GetColorGap() const;
 
-        void SetWidth( long nWidth = 0 );
+        void SetWidth( long nWidth );
         /** Guess the style and width from the three lines widths values.
 
             When the value of nStyle is SvxBorderLine::DOUBLE, the style set will be guessed
diff --git a/include/editeng/boxitem.hxx b/include/editeng/boxitem.hxx
index 83c42e296810..73f66d9cc982 100644
--- a/include/editeng/boxitem.hxx
+++ b/include/editeng/boxitem.hxx
@@ -106,7 +106,7 @@ public:
     void    SetDistance( sal_uInt16 nNew, SvxBoxItemLine nLine );
     inline void SetAllDistances( sal_uInt16 nNew );
 
-    void SetRemoveAdjacentCellBorder( bool bSet = true ) { bRemoveAdjCellBorder = bSet; }
+    void SetRemoveAdjacentCellBorder( bool bSet ) { bRemoveAdjCellBorder = bSet; }
 
     // Line width plus Space plus inward distance
     // bIgnoreLine = TRUE -> Also return distance, when no Line is set
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index a20c996be8bc..d30b3b00dca1 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -158,7 +158,7 @@ private:
 
                                        EditEngine( const EditEngine& ) = delete;
                        EditEngine&     operator=( const EditEngine& ) = delete;
-    EDITENG_DLLPRIVATE bool            PostKeyEvent( const KeyEvent& rKeyEvent, EditView* pView, vcl::Window* pFrameWin = nullptr );
+    EDITENG_DLLPRIVATE bool            PostKeyEvent( const KeyEvent& rKeyEvent, EditView* pView, vcl::Window* pFrameWin );
 
     EDITENG_DLLPRIVATE void CursorMoved(ContentNode* pPrevNode);
     EDITENG_DLLPRIVATE void CheckIdleFormatter();
@@ -227,7 +227,7 @@ public:
 
     void            InsertView(EditView* pEditView, size_t nIndex = EE_APPEND);
     EditView*       RemoveView( EditView* pEditView );
-    void            RemoveView(size_t nIndex = EE_APPEND);
+    void            RemoveView(size_t nIndex);
     EditView*       GetView(size_t nIndex = 0) const;
     size_t          GetViewCount() const;
     bool            HasView( EditView* pView ) const;
@@ -326,7 +326,7 @@ public:
 
     void            RemoveAttribs( const ESelection& rSelection, bool bRemoveParaAttribs, sal_uInt16 nWhich );
 
-    void            ShowParagraph( sal_Int32 nParagraph, bool bShow = true );
+    void            ShowParagraph( sal_Int32 nParagraph, bool bShow );
 
     ::svl::IUndoManager& GetUndoManager();
     ::svl::IUndoManager* SetUndoManager(::svl::IUndoManager* pNew);
@@ -358,7 +358,7 @@ public:
     long            GetFirstLineStartX( sal_Int32 nParagraph );
     Point           GetDocPosTopLeft( sal_Int32 nParagraph );
     Point           GetDocPos( const Point& rPaperPos ) const;
-    bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder = 0 );
+    bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder );
 
     // StartDocPos corresponds to VisArea.TopLeft().
     void            Draw( OutputDevice* pOutDev, const Rectangle& rOutRect );
@@ -395,7 +395,7 @@ public:
     void            QuickDelete( const ESelection& rSel );
     void            QuickMarkToBeRepainted( sal_Int32 nPara );
 
-    void            SetGlobalCharStretching( sal_uInt16 nX = 100, sal_uInt16 nY = 100 );
+    void            SetGlobalCharStretching( sal_uInt16 nX, sal_uInt16 nY = 100 );
     void            GetGlobalCharStretching( sal_uInt16& rX, sal_uInt16& rY ) const;
 
     void            SetEditTextObjectPool( SfxItemPool* pPool );
@@ -547,7 +547,7 @@ public:
 
     EditPaM CreateEditPaM(const EPaM& rEPaM);
     EditPaM ConnectParagraphs(
-        ContentNode* pLeft, ContentNode* pRight, bool bBackward = false);
+        ContentNode* pLeft, ContentNode* pRight, bool bBackward);
 
     EditPaM InsertField(const EditSelection& rEditSelection, const SvxFieldItem& rFld);
     EditPaM InsertText(const EditSelection& aCurEditSelection, const OUString& rStr);
@@ -593,13 +593,13 @@ public:
     EditSelection MoveParagraphs(const Range& rParagraphs, sal_Int32 nNewPos, EditView* pCurView);
 
     void RemoveCharAttribs(sal_Int32 nPara, sal_uInt16 nWhich = 0, bool bRemoveFeatures = false);
-    void RemoveCharAttribs(const EditSelection& rSel, bool bRemoveParaAttribs, sal_uInt16 nWhich = 0);
+    void RemoveCharAttribs(const EditSelection& rSel, bool bRemoveParaAttribs, sal_uInt16 nWhich);
 
     ViewsType& GetEditViews();
     const ViewsType& GetEditViews() const;
 
     void SetUndoMode(bool b);
-    void FormatAndUpdate(EditView* pCurView = nullptr);
+    void FormatAndUpdate(EditView* pCurView);
 
     void Undo(EditView* pView);
     void Redo(EditView* pView);
diff --git a/include/editeng/editobj.hxx b/include/editeng/editobj.hxx
index a3ab3a9e5bb5..6920d0628c10 100644
--- a/include/editeng/editobj.hxx
+++ b/include/editeng/editobj.hxx
@@ -110,7 +110,7 @@ public:
 
     void GetCharAttribs( sal_Int32 nPara, std::vector<EECharAttrib>& rLst ) const;
 
-    bool RemoveCharAttribs( sal_uInt16 nWhich = 0 );
+    bool RemoveCharAttribs( sal_uInt16 nWhich );
 
     /**
      * Get all text sections in this content.  Sections are non-overlapping
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index 3175cd0d10c8..7c28a75e387e 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -174,10 +174,10 @@ public:
     SfxItemSet          GetAttribs();
     void                SetAttribs( const SfxItemSet& rSet );
     void                RemoveAttribs( bool bRemoveParaAttribs = false, sal_uInt16 nWhich = 0 );
-    void                RemoveCharAttribs( sal_Int32 nPara, sal_uInt16 nWhich = 0 );
-    void                RemoveAttribsKeepLanguages( bool bRemoveParaAttribs = false );
+    void                RemoveCharAttribs( sal_Int32 nPara, sal_uInt16 nWhich );
+    void                RemoveAttribsKeepLanguages( bool bRemoveParaAttribs );
 
-    sal_uInt32          Read( SvStream& rInput, const OUString& rBaseURL, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs = nullptr );
+    sal_uInt32          Read( SvStream& rInput, const OUString& rBaseURL, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs );
 
     void            SetBackgroundColor( const Color& rColor );
     Color           GetBackgroundColor() const;
@@ -217,7 +217,7 @@ public:
 
     bool            IsCursorAtWrongSpelledWord();
     bool            IsWrongSpelledWordAtPos( const Point& rPosPixel, bool bMarkIfWrong = false );
-    void            ExecuteSpellPopup( const Point& rPosPixel, Link<SpellCallbackInfo&,void>* pCallBack = nullptr );
+    void            ExecuteSpellPopup( const Point& rPosPixel, Link<SpellCallbackInfo&,void>* pCallBack );
 
     void                InsertField( const SvxFieldItem& rFld );
     const SvxFieldItem* GetFieldUnderMousePointer() const;
diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx
index 064d68a640e6..084fcb263f2e 100644
--- a/include/editeng/lrspitem.hxx
+++ b/include/editeng/lrspitem.hxx
@@ -115,7 +115,7 @@ public:
 
     inline void   SetTextFirstLineOfst( const short nF, const sal_uInt16 nProp = 100 );
     inline short  GetTextFirstLineOfst() const { return nFirstLineOfst; }
-    inline void SetPropTextFirstLineOfst( const sal_uInt16 nProp = 100 )
+    inline void SetPropTextFirstLineOfst( const sal_uInt16 nProp )
                     { nPropFirstLineOfst = nProp; }
     inline sal_uInt16 GetPropTextFirstLineOfst() const
                     { return nPropFirstLineOfst; }
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 90df8d6cc872..913f6f9f60b6 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -256,7 +256,7 @@ public:
 
     void        AdjustHeight( long nDY );
 
-    sal_uLong   Read( SvStream& rInput, const OUString& rBaseURL, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs = nullptr );
+    sal_uLong   Read( SvStream& rInput, const OUString& rBaseURL, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs );
 
     void        InsertText( const OUString& rNew, bool bSelect = false );
     void        InsertText( const OutlinerParaObject& rParaObj );
@@ -307,7 +307,7 @@ public:
     void        SetSelection( const ESelection& );
     void GetSelectionRectangles(std::vector<Rectangle>& rLogicRects) const;
 
-    void        RemoveAttribs( bool bRemoveParaAttribs = false, bool bKeepLanguages = false );
+    void        RemoveAttribs( bool bRemoveParaAttribs, bool bKeepLanguages = false );
     void        RemoveAttribsKeepLanguages( bool bRemoveParaAttribs );
     bool        HasSelection() const;
 
@@ -323,7 +323,7 @@ public:
     void ToggleBulletsNumbering(
         const bool bToggle,
         const bool bHandleBullets,
-        const SvxNumRule* pNumRule = nullptr );
+        const SvxNumRule* pNumRule );
 
     /** apply bullets/numbering for paragraphs
 
@@ -360,7 +360,7 @@ public:
 
     bool        IsCursorAtWrongSpelledWord();
     bool        IsWrongSpelledWordAtPos( const Point& rPosPixel, bool bMarkIfWrong = false );
-    void        ExecuteSpellPopup( const Point& rPosPixel, Link<SpellCallbackInfo&,void>* pCallBack = nullptr );
+    void        ExecuteSpellPopup( const Point& rPosPixel, Link<SpellCallbackInfo&,void>* pCallBack );
 
     void        SetInvalidateMore( sal_uInt16 nPixel );
     sal_uInt16  GetInvalidateMore() const;
@@ -942,7 +942,7 @@ public:
     sal_uLong       GetTextHeight( sal_Int32 nParagraph ) const;
     Point           GetDocPosTopLeft( sal_Int32 nParagraph );
     Point           GetDocPos( const Point& rPaperPos ) const;
-    bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder = 0 );
+    bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder );
     bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder, bool* pbBulletPos );
 
     void            SetGlobalCharStretching( sal_uInt16 nX = 100, sal_uInt16 nY = 100 );
diff --git a/include/editeng/paperinf.hxx b/include/editeng/paperinf.hxx
index d135170582c7..566e741b81e0 100644
--- a/include/editeng/paperinf.hxx
+++ b/include/editeng/paperinf.hxx
@@ -39,7 +39,7 @@ public:
     static Size     GetDefaultPaperSize( MapUnit eUnit = MAP_TWIP );
     static Size     GetPaperSize( Paper ePaper, MapUnit eUnit = MAP_TWIP );
     static Size     GetPaperSize( const Printer* pPrinter );
-    static Paper    GetSvxPaper( const Size &rSize, MapUnit eUnit = MAP_TWIP, bool bSloppy = false );
+    static Paper    GetSvxPaper( const Size &rSize, MapUnit eUnit, bool bSloppy = false );
     static long     GetSloppyPaperDimension( long nSize );
     static OUString GetName( Paper ePaper );
 };
diff --git a/include/editeng/svxacorr.hxx b/include/editeng/svxacorr.hxx
index d5dc16da4654..dbe2704ba728 100644
--- a/include/editeng/svxacorr.hxx
+++ b/include/editeng/svxacorr.hxx
@@ -329,49 +329,42 @@ public:
     void SetAutoCorrFlag( long nFlag, bool bOn = true );
 
     // Load, Set, Get - the replacement list
-    SvxAutocorrWordList* LoadAutocorrWordList(
-                                    LanguageType eLang = LANGUAGE_SYSTEM )
+    SvxAutocorrWordList* LoadAutocorrWordList( LanguageType eLang )
         { return GetLanguageList_( eLang ).LoadAutocorrWordList(); }
 
     // Save word substitutions:
     //      Save these directly in the storage. The word list is updated
     //      accordingly!
     //  - pure Text
-    bool PutText( const OUString& rShort, const OUString& rLong, LanguageType eLang = LANGUAGE_SYSTEM );
+    bool PutText( const OUString& rShort, const OUString& rLong, LanguageType eLang );
     //  - Text with attribution (only in the SWG - SWG format!)
-    void PutText( const OUString& rShort, SfxObjectShell& rShell,
-                 LanguageType eLang = LANGUAGE_SYSTEM )
+    void PutText( const OUString& rShort, SfxObjectShell& rShell, LanguageType eLang )
         { GetLanguageList_( eLang ).PutText(rShort, rShell ); }
 
     void MakeCombinedChanges( std::vector<SvxAutocorrWord>& aNewEntries,
                                   std::vector<SvxAutocorrWord>& aDeleteEntries,
-                                  LanguageType eLang = LANGUAGE_SYSTEM );
+                                  LanguageType eLang );
 
     // Load, Set, Get - the exception list for capital letters at the
     // beginning of a sentence
     void SaveCplSttExceptList( LanguageType eLang = LANGUAGE_SYSTEM );
-    SvStringsISortDtor* LoadCplSttExceptList(
-                                    LanguageType eLang = LANGUAGE_SYSTEM)
+    SvStringsISortDtor* LoadCplSttExceptList(LanguageType eLang)
         {   return GetLanguageList_( eLang ).LoadCplSttExceptList(); }
-    const SvStringsISortDtor* GetCplSttExceptList(
-                                    LanguageType eLang = LANGUAGE_SYSTEM )
+    const SvStringsISortDtor* GetCplSttExceptList( LanguageType eLang )
         {   return GetLanguageList_( eLang ).GetCplSttExceptList(); }
 
     // Adds a single word. The list will be immediately written to the file!
-    bool AddCplSttException( const OUString& rNew,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+    bool AddCplSttException( const OUString& rNew, LanguageType eLang );
 
     // Load, Set, Get the exception list for 2 Capital letters at the
     // beginning of a word.
-    void SaveWrdSttExceptList( LanguageType eLang = LANGUAGE_SYSTEM );
-    SvStringsISortDtor* LoadWrdSttExceptList(
-                                    LanguageType eLang = LANGUAGE_SYSTEM )
+    void SaveWrdSttExceptList( LanguageType eLang );
+    SvStringsISortDtor* LoadWrdSttExceptList( LanguageType eLang )
         {   return GetLanguageList_( eLang ).LoadWrdSttExceptList(); }
-    const SvStringsISortDtor* GetWrdSttExceptList(
-                                    LanguageType eLang = LANGUAGE_SYSTEM )
+    const SvStringsISortDtor* GetWrdSttExceptList( LanguageType eLang )
         {   return GetLanguageList_( eLang ).GetWrdSttExceptList(); }
     // Adds a single word. The list will be immediately written to the file!
-    bool AddWrtSttException( const OUString& rNew, LanguageType eLang = LANGUAGE_SYSTEM);
+    bool AddWrtSttException( const OUString& rNew, LanguageType eLang);
 
     // Search through the Languages for the entry
     bool FindInWrdSttExceptList( LanguageType eLang, const OUString& sWord );
@@ -381,27 +374,27 @@ public:
     // Methods for the auto-correction
     bool FnCapitalStartWord( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+                                LanguageType eLang );
     bool FnChgOrdinalNumber( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+                                LanguageType eLang );
     bool FnChgToEnEmDash( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+                                LanguageType eLang );
     bool FnAddNonBrkSpace( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+                                LanguageType eLang );
     bool FnSetINetAttr( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang = LANGUAGE_SYSTEM );
+                                LanguageType eLang );
     bool FnChgWeightUnderl( SvxAutoCorrDoc&, const OUString&,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos );
     bool FnCapitalStartSentence( SvxAutoCorrDoc&, const OUString&, bool bNormalPos,
                                 sal_Int32 nSttPos, sal_Int32 nEndPos,
-                                LanguageType eLang  = LANGUAGE_SYSTEM);
+                                LanguageType eLang);
     bool FnCorrectCapsLock( SvxAutoCorrDoc&, const OUString&,
                             sal_Int32 nSttPos, sal_Int32 nEndPos,
-                            LanguageType eLang  = LANGUAGE_SYSTEM );
+                            LanguageType eLang );
 
     bool                HasRunNext() { return bRunNext; }
 
diff --git a/include/editeng/unoedprx.hxx b/include/editeng/unoedprx.hxx
index 8ec9c616b083..68b96f373bab 100644
--- a/include/editeng/unoedprx.hxx
+++ b/include/editeng/unoedprx.hxx
@@ -147,7 +147,7 @@ public:
     SvxAccessibleTextAdapter*                   GetTextForwarderAdapter(); // covariant return types don't work on MSVC
     virtual SvxViewForwarder*                   GetViewForwarder() override;
     virtual SvxEditViewForwarder*               GetEditViewForwarder( bool bCreate = false ) override;
-    SvxAccessibleTextEditViewAdapter*           GetEditViewForwarderAdapter( bool bCreate = false ); // covariant return types don't work on MSVC
+    SvxAccessibleTextEditViewAdapter*           GetEditViewForwarderAdapter( bool bCreate ); // covariant return types don't work on MSVC
     virtual void                                UpdateData() override;
     virtual SfxBroadcaster&                     GetBroadcaster() const override;