diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-01-28 10:31:00 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-01-28 13:52:34 +0100 |
| commit | f7c4c6313dbe305d9dd2f7a0c49f436033bbf62e (patch) | |
| tree | c65d1ea0a55eec6ed8af5910f17046e51fe2ce39 /include/editeng | |
| parent | c67b490637b586616b46db349b1215296daa34e3 (diff) | |
SvxAccessibleTextIndex::mnEEIndex need not be bounded sal_uInt16
It was originally introduced with type USHORT
(a909acb7009acadffa53e74ea05ddb88803490f1 "#98735# Refactored
unoedit/unoedacc.cxx"), then shortly after changed to sal_Int32
(a0089a21f047ce8b5378b45f1535269e3600d681 "#98735# Fixed various off-by-one
mistakes"), presumably because it needed to hold values slightly larger than
USHRT_MAX.
But at least since the surrounding code has been changed to use sal_Int32
throughout (e.g., structs like EPosition and ESeleciton in
include/editeng/editdata.hxx with 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5
"xub_StrLen and tools/string.hxx final straw"), there appears to be no more
reason to effectively restrict mnEEIndex to sal_uInt16 values.
Change-Id: I78f02be1f2736a626a836ac992230a74cc669fd3
Reviewed-on: https://gerrit.libreoffice.org/48766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/editeng')
| -rw-r--r-- | include/editeng/unoedprx.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/editeng/unoedprx.hxx b/include/editeng/unoedprx.hxx index 39bc5f163b6d..559c0390294e 100644 --- a/include/editeng/unoedprx.hxx +++ b/include/editeng/unoedprx.hxx @@ -42,7 +42,7 @@ public: virtual void RemoveAttribs( const ESelection& rSelection ) override; virtual void GetPortions( sal_Int32 nPara, std::vector<sal_Int32>& rList ) const override; - sal_uInt16 CalcEditEngineIndex( sal_Int32 nPara, sal_Int32 nLogicalIndex ); + sal_Int32 CalcEditEngineIndex( sal_Int32 nPara, sal_Int32 nLogicalIndex ); virtual SfxItemState GetItemState( const ESelection& rSel, sal_uInt16 nWhich ) const override; virtual SfxItemState GetItemState( sal_Int32 nPara, sal_uInt16 nWhich ) const override; |