diff options
| author | Noel Grandin <noel@peralex.com> | 2021-01-25 14:43:05 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-01-25 17:54:54 +0100 |
| commit | aa98ed61a7b1e50bcc4f64ceaea3bb0cda360bb4 (patch) | |
| tree | 6dbb2acb28f34084275138afa6bbe047c960697c /include/formula | |
| parent | 46e525c36e62c7cb365f1a1f34373e726cfb49b7 (diff) | |
tdf#92456 improve VLOOKUP perf
shave 5% of the time here - ref-counting triggered by copying
svl::SharedString is significant, so return by const&
instead of by value
Change-Id: Ic702632da45d75dddab33d6ce1e6f1097ff70de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109900
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/formula')
| -rw-r--r-- | include/formula/token.hxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/formula/token.hxx b/include/formula/token.hxx index 4fc6b382d4cd..3fa00e89339f 100644 --- a/include/formula/token.hxx +++ b/include/formula/token.hxx @@ -181,7 +181,7 @@ public: virtual double& GetDoubleAsReference(); virtual sal_Int16 GetDoubleType() const; virtual void SetDoubleType( sal_Int16 nType ); - virtual svl::SharedString GetString() const; + virtual const svl::SharedString & GetString() const; virtual void SetString( const svl::SharedString& rStr ); virtual sal_uInt16 GetIndex() const; virtual void SetIndex( sal_uInt16 n ); @@ -320,7 +320,7 @@ public: FormulaStringToken( const FormulaStringToken& r ); virtual FormulaToken* Clone() const override; - virtual svl::SharedString GetString() const override; + virtual const svl::SharedString & GetString() const override; virtual void SetString( const svl::SharedString& rStr ) override; virtual bool operator==( const FormulaToken& rToken ) const override; }; @@ -336,7 +336,7 @@ public: FormulaStringOpToken( const FormulaStringOpToken& r ); virtual FormulaToken* Clone() const override; - virtual svl::SharedString GetString() const override; + virtual const svl::SharedString & GetString() const override; virtual void SetString( const svl::SharedString& rStr ) override; virtual bool operator==( const FormulaToken& rToken ) const override; }; @@ -391,7 +391,7 @@ public: virtual FormulaToken* Clone() const override { return new FormulaMissingToken(*this); } virtual double GetDouble() const override; - virtual svl::SharedString GetString() const override; + virtual const svl::SharedString & GetString() const override; virtual bool operator==( const FormulaToken& rToken ) const override; }; |