new loplugin:conststringfield

Look for const string fields which can be static, and
mostly convert them to OUStringLiteral

And add a getLength() method to OUStringLiteral to make
the transition easier.

Remove dead code in XclExpRoot::GenerateDefaultEncryptionData,
default password is never empty.

Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091
Reviewed-on: https://gerrit.libreoffice.org/59204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 0 insertions, 6 deletions

diff --git a/include/oox/helper/modelobjecthelper.hxx b/include/oox/helper/modelobjecthelper.hxx
index eb9c7ba97228..5b5dea4f4092 100644
--- a/include/oox/helper/modelobjecthelper.hxx
+++ b/include/oox/helper/modelobjecthelper.hxx
@@ -117,10 +117,6 @@ private:
     ObjectContainer     maGradientContainer;    ///< Contains all named fill gradients.
     ObjectContainer     maTransGradContainer;   ///< Contains all named transparency Gradients.
     ObjectContainer     maBitmapUrlContainer;   ///< Contains all named fill bitmap URLs.
-    const OUString      maDashNameBase;       ///< Base name for all named line dashes.
-    const OUString      maGradientNameBase;   ///< Base name for all named fill gradients.
-    const OUString      maTransGradNameBase;   ///< Base name for all named fill gradients.
-    const OUString      maBitmapUrlNameBase;  ///< Base name for all named fill bitmap URLs.
 };
 
 
diff --git a/include/oox/vml/vmlinputstream.hxx b/include/oox/vml/vmlinputstream.hxx
index ed5db08330f4..54b93bbe4344 100644
--- a/include/oox/vml/vmlinputstream.hxx
+++ b/include/oox/vml/vmlinputstream.hxx
@@ -90,8 +90,6 @@ private:
                         mxTextStrm;
     css::uno::Sequence< sal_Unicode > maOpeningBracket;
     css::uno::Sequence< sal_Unicode > maClosingBracket;
-    const OString       maOpeningCData;
-    const OString       maClosingCData;
     OString             maBuffer;
     sal_Int32           mnBufferPos;
 };