diff options
author | Armin Le Grand (Allotropia) <Armin.Le.Grand@me.com> | 2022-03-04 16:51:07 +0100 |
---|---|---|
committer | Armin Le Grand <Armin.Le.Grand@me.com> | 2022-03-04 22:10:10 +0100 |
commit | 9c526b557e264280cb0c9da704245494f5ec5af3 (patch) | |
tree | 2ea8393b8ea5a7e24088b116320fb9bfaeb1f136 /include/oox | |
parent | 35428625b70829ba56da99fafe205b24b0018ace (diff) |
Advanced Diagram support: Allow reLayout without keeping oox::Shape
Goal is to minimize dependencies on oox classes. For that pupose
I redesigned the Diagram class to work without remembering
an oox::Shape at all. For reLayout, a new temporary one is created
and used. That was a bit tricky, I needed to find out what
data at the oox::Shape is needed to sucessfully do that with
the not-originally-imported one.
Another necessary change was to move the DiagramFontHeights
adapting mechanism away from oox::Shape, too. It fits better
to Diagram class. That way it can also be used for reLayout
and the oox::Shape gets a little bit smaller, too.
This opens the path to move needed Mode-Data Diagam core
claasses to other libs where changing/im/exPorting them will
be possible.
Change-Id: I40bc4b190d2abc797f5c56f9e476d22155d21422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131004
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Diffstat (limited to 'include/oox')
-rw-r--r-- | include/oox/drawingml/shape.hxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/include/oox/drawingml/shape.hxx b/include/oox/drawingml/shape.hxx index 6bd875656632..d3fd710954a5 100644 --- a/include/oox/drawingml/shape.hxx +++ b/include/oox/drawingml/shape.hxx @@ -247,8 +247,6 @@ public: void keepDiagramDrawing(::oox::core::XmlFilterBase& rFilterBase, const OUString& rFragmentPath); - oox::core::NamedShapePairs& getDiagramFontHeights() { return maDiagramFontHeights; } - // Allows preparation of a local Diagram helper && propagate an eventually // existing one to the data holder object later void prepareDiagramHelper(const std::shared_ptr< Diagram >& rDiagramPtr, const std::shared_ptr<::oox::drawingml::Theme>& rTheme); @@ -290,7 +288,6 @@ protected: const basegfx::B2DHomMatrix& aTransformation ); void keepDiagramCompatibilityInfo(); - void syncDiagramFontHeights(); void convertSmartArtToMetafile( ::oox::core::XmlFilterBase const& rFilterBase ); css::uno::Reference< css::drawing::XShape > @@ -397,9 +394,6 @@ private: /// The shape fill should be set to that of the slide background surface. bool mbUseBgFill = false; - /// For SmartArt, this contains groups of shapes: automatic font size is the same in each group. - oox::core::NamedShapePairs maDiagramFontHeights; - // temporary space for DiagramHelper in preparation for collecting data // Note: I tried to use a unique_ptr here, but existing constuctor func does not allow that IDiagramHelper* mpDiagramHelper; |