diff options
| author | Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> | 2020-12-10 14:24:05 +0100 |
|---|---|---|
| committer | Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> | 2021-04-19 09:22:57 +0200 |
| commit | eac00017e34e77343b9ac3638bed9c75115a23fe (patch) | |
| tree | cdbfb83b09325602e5ef1099051390413ad0a93c /include/osl | |
| parent | 9f06c54ca1819b6d4df48f33772cfa5ceb90dccd (diff) | |
[API CHANGE] Do not call getaddrinfo if we just want the hostname
Similiar to afc41a467fdfabb2cd0879be3e4f1879a1d1dc91 ,
don't call getaddrinfo in getLocalHostname which calls DNS.
This causes a lag when creating the lockfile on opening a document
if the network is flaky/disabled.
See tdf#97931 and tdf#47179 for some problems caused by this.
For the one case where it is expected to call DNS, add a separate function
to restore the old behavior.
The (semantic) [API CHANGE] is in osl_getLocalHostname,
it does no longer return a FQDN.
Change-Id: I43455715a474ff6770351d1ce007c28aeb08f32e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107554
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Diffstat (limited to 'include/osl')
| -rw-r--r-- | include/osl/socket.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/osl/socket.h b/include/osl/socket.h index 864e8df88d84..0492dd3179ab 100644 --- a/include/osl/socket.h +++ b/include/osl/socket.h @@ -906,8 +906,7 @@ SAL_DLLPUBLIC void SAL_CALL osl_getHostnameOfHostAddr(const oslHostAddr Addr, rt */ SAL_DLLPUBLIC oslSocketAddr SAL_CALL osl_getSocketAddrOfHostAddr(const oslHostAddr Addr); -/** Retrieve this machines hostname. - May not always be a fully qualified domain name (FQDN). +/** Retrieve this machines hostname (NOT the FQDN) @param strLocalHostname out-parameter. The string that receives the local host name. @retval sal_True upon success @retval sal_False |