loplugin:constantparam in registry

Change-Id: Ic3c60325a722422912d06fe21d072c5f5c4bccb1
Reviewed-on: https://gerrit.libreoffice.org/23322
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

2 files changed, 4 insertions, 19 deletions

diff --git a/include/registry/reader.hxx b/include/registry/reader.hxx
index 0e2da0735431..6d3deb8f63d5 100644
--- a/include/registry/reader.hxx
+++ b/include/registry/reader.hxx
@@ -59,23 +59,11 @@ public:
 
        @param length the size in bytes of the binary blob representing the type
 
-       @param copy if true, the type reader creates an internal copy of the
-       given buffer, and the given buffer is not accessed after this constructor
-       returns; if false, the type reader works directly on the given buffer,
-       which must remain available unmodified until the underlying type reader
-       is destroyed (note that the lifetime of the underlying type reader can be
-       different from the lifetime of this <code>Reader</code> instance)
-
-       @param maxVersion the maximum binary blob version the client is prepared
-       to handle; must not be negative
-
        @exception std::bad_alloc is raised if an out-of-memory condition occurs
      */
-    Reader(
-        void const * buffer, sal_uInt32 length, bool copy,
-        typereg_Version maxVersion)
+    Reader(void const * buffer, sal_uInt32 length)
     {
-        if (!typereg_reader_create(buffer, length, copy, maxVersion, &m_handle))
+        if (!typereg_reader_create(buffer, length, false/*copy*/, TYPEREG_VERSION_1, &m_handle))
         {
             throw std::bad_alloc();
         }
diff --git a/include/registry/registry.hxx b/include/registry/registry.hxx
index e9cbff830f4f..9309e7ff0311 100644
--- a/include/registry/registry.hxx
+++ b/include/registry/registry.hxx
@@ -558,12 +558,10 @@ public:
 
         @param[in]  keyName specifies the name of the key which will be resolved relative to this key.
                         The resolved name will be prefixed with the name of this key.
-        @param[in]  firstLinkOnly ignored
         @param[out] rResolvedName the resolved name.
         @return RegError::NO_ERROR if succeeds else an error code.
      */
     inline RegError getResolvedKeyName(const rtl::OUString& keyName,
-                                       bool firstLinkOnly,
                                            rtl::OUString& rResolvedName) const;
 
     /// returns the name of the registry in which the key is defined.
@@ -994,13 +992,12 @@ inline RegError RegistryKey::getLinkTarget(const rtl::OUString& ,
 
 
 inline RegError RegistryKey::getResolvedKeyName(const rtl::OUString& keyName,
-                                                bool firstLinkOnly,
-                                                       rtl::OUString& rResolvedName) const
+                                                      rtl::OUString& rResolvedName) const
     {
         if (m_registry.isValid())
             return m_registry.m_pApi->getResolvedKeyName(m_hImpl,
                                                          keyName.pData,
-                                                         firstLinkOnly,
+                                                         true,
                                                          &rResolvedName.pData);
         else
             return RegError::INVALID_KEY;