make *String(string_view) constructors explicit

to make it more obvious when we are constructing heap OUStrings
code and potentially inadvertently throwing away performance.

And fix a handful of places so revealed.

Change-Id: I0cf390f78026f8a670aaab53424cd31510633051
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 1 deletions

diff --git a/include/rtl/string.hxx b/include/rtl/string.hxx
index 3c540198f95f..e5e7f5716b74 100644
--- a/include/rtl/string.hxx
+++ b/include/rtl/string.hxx
@@ -329,7 +329,7 @@ public:
 #endif
 
 #if defined LIBO_INTERNAL_ONLY
-    OString(std::string_view sv) {
+    explicit OString(std::string_view sv) {
         if (sv.size() > sal_uInt32(std::numeric_limits<sal_Int32>::max())) {
             throw std::bad_alloc();
         }