summaryrefslogtreecommitdiff
path: root/include/rtl
diff options
context:
space:
mode:
authorNoel Grandin <noelgrandin@gmail.com>2020-12-17 22:02:06 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2020-12-19 17:53:06 +0100
commit46c5de832868d2812448b2caace3eeaa9237b9f6 (patch)
tree6f25538cfb7a0def54ff7ac5b6b17eb22a76178a /include/rtl
parent6dd1d2268487920e8bda44dfd169a5bda4d62f13 (diff)
make *String(string_view) constructors explicit
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/rtl')
-rw-r--r--include/rtl/string.hxx2
-rw-r--r--include/rtl/ustring.hxx2
2 files changed, 2 insertions, 2 deletions
diff --git a/include/rtl/string.hxx b/include/rtl/string.hxx
index 3c540198f95f..e5e7f5716b74 100644
--- a/include/rtl/string.hxx
+++ b/include/rtl/string.hxx
@@ -329,7 +329,7 @@ public:
#endif
#if defined LIBO_INTERNAL_ONLY
- OString(std::string_view sv) {
+ explicit OString(std::string_view sv) {
if (sv.size() > sal_uInt32(std::numeric_limits<sal_Int32>::max())) {
throw std::bad_alloc();
}
diff --git a/include/rtl/ustring.hxx b/include/rtl/ustring.hxx
index 9f8d08c8f9a5..270eedd2c32d 100644
--- a/include/rtl/ustring.hxx
+++ b/include/rtl/ustring.hxx
@@ -468,7 +468,7 @@ public:
#endif
#if defined LIBO_INTERNAL_ONLY
- OUString(std::u16string_view sv) {
+ explicit OUString(std::u16string_view sv) {
if (sv.size() > sal_uInt32(std::numeric_limits<sal_Int32>::max())) {
throw std::bad_alloc();
}