clang-tidy modernize-pass-by-value in sfx2

Change-Id: I7984f0b52809091511dc01005fdbfeafd521b4bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137048
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 7 insertions, 8 deletions

diff --git a/include/sfx2/sidebar/AsynchronousCall.hxx b/include/sfx2/sidebar/AsynchronousCall.hxx
index 0f2377abc511..c7e522401d5a 100644
--- a/include/sfx2/sidebar/AsynchronousCall.hxx
+++ b/include/sfx2/sidebar/AsynchronousCall.hxx
@@ -33,7 +33,7 @@ class AsynchronousCall
 public:
     typedef ::std::function<void()> Action;
 
-    AsynchronousCall(const Action& rAction);
+    AsynchronousCall(Action aAction);
     ~AsynchronousCall();
 
     void RequestCall();
diff --git a/include/sfx2/sidebar/Context.hxx b/include/sfx2/sidebar/Context.hxx
index f4ca42d753d8..c1ea1f5e4aea 100644
--- a/include/sfx2/sidebar/Context.hxx
+++ b/include/sfx2/sidebar/Context.hxx
@@ -31,7 +31,7 @@ public:
     OUString msContext;
 
     Context();
-    Context(const OUString& rsApplication, const OUString& rsContext);
+    Context(OUString sApplication, OUString sContext);
 
     /** When two contexts are matched against each other, then
         application or context name may have the wildcard value 'any'.
diff --git a/include/sfx2/sidebar/FocusManager.hxx b/include/sfx2/sidebar/FocusManager.hxx
index c51ccbfa832f..7236e1f84c85 100644
--- a/include/sfx2/sidebar/FocusManager.hxx
+++ b/include/sfx2/sidebar/FocusManager.hxx
@@ -50,7 +50,7 @@ class DeckTitleBar;
 class FocusManager
 {
 public:
-    FocusManager(const std::function<void(const Panel&)>& rShowPanelFunctor);
+    FocusManager(std::function<void(const Panel&)> aShowPanelFunctor);
     ~FocusManager();
 
     /** Forget all panels and buttons.  Remove all window listeners.
diff --git a/include/sfx2/sidebar/Panel.hxx b/include/sfx2/sidebar/Panel.hxx
index 1c0af8ad249c..c04c6a53a1b9 100644
--- a/include/sfx2/sidebar/Panel.hxx
+++ b/include/sfx2/sidebar/Panel.hxx
@@ -54,8 +54,7 @@ class SFX2_DLLPUBLIC Panel final
 {
 public:
     Panel(const PanelDescriptor& rPanelDescriptor, weld::Widget* pParentWindow,
-          const bool bIsInitiallyExpanded, Deck* pDeck,
-          const std::function<Context()>& rContextAccess,
+          const bool bIsInitiallyExpanded, Deck* pDeck, std::function<Context()> aContextAccess,
           const css::uno::Reference<css::frame::XFrame>& rxFrame);
 
     ~Panel();
diff --git a/include/sfx2/sidebar/SidebarPanelBase.hxx b/include/sfx2/sidebar/SidebarPanelBase.hxx
index b00d4ca3cead..c1c99cd24a19 100644
--- a/include/sfx2/sidebar/SidebarPanelBase.hxx
+++ b/include/sfx2/sidebar/SidebarPanelBase.hxx
@@ -83,7 +83,7 @@ public:
     void SetParentPanel(sfx2::sidebar::Panel* pPanel);
 
 private:
-    SidebarPanelBase(const OUString& rsResourceURL, const css::uno::Reference<css::frame::XFrame>& rxFrame,
+    SidebarPanelBase(OUString sResourceURL, css::uno::Reference<css::frame::XFrame> xFrame,
                      std::unique_ptr<PanelLayout> xControl, const css::ui::LayoutSize& rLayoutSize);
     virtual ~SidebarPanelBase() override;
     SidebarPanelBase(const SidebarPanelBase&) = delete;
diff --git a/include/sfx2/sidebar/TabBar.hxx b/include/sfx2/sidebar/TabBar.hxx
index 5cc092c239de..fcbced33fa98 100644
--- a/include/sfx2/sidebar/TabBar.hxx
+++ b/include/sfx2/sidebar/TabBar.hxx
@@ -58,8 +58,8 @@ public:
     TabBar (
         vcl::Window* pParentWindow,
         const css::uno::Reference<css::frame::XFrame>& rxFrame,
-        const ::std::function<void (const OUString& rsDeckId)>& rDeckActivationFunctor,
-        const PopupMenuProvider& rPopupMenuProvider,
+        ::std::function<void (const OUString& rsDeckId)> aDeckActivationFunctor,
+        PopupMenuProvider aPopupMenuProvider,
         SidebarController* rParentSidebarController);
 
     weld::Container* GetContainer() { return m_xContainer.get(); }