clang-tidy performance-unnecessary-value-param in sfx2

Change-Id: I035eec1f3701c48b9a85c60400c68f9365299b48

10 files changed, 17 insertions, 17 deletions

diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx
index bbf9c4e37298..150b03747b3c 100644
--- a/include/sfx2/docfile.hxx
+++ b/include/sfx2/docfile.hxx
@@ -116,7 +116,7 @@ public:
     /**
      * Does not take ownership of pFlt but pFlt needs to be around as long as the SfxMedium instance.
      */
-    void                SetFilter(std::shared_ptr<const SfxFilter> pFilter);
+    void                SetFilter(const std::shared_ptr<const SfxFilter>& pFilter);
     std::shared_ptr<const SfxFilter>    GetFilter() const;
     std::shared_ptr<const SfxFilter>    GetOrigFilter() const;
     const OUString&     GetOrigURL() const;
diff --git a/include/sfx2/docinf.hxx b/include/sfx2/docinf.hxx
index 0c1b66f1c38e..1c75d1d9bc3c 100644
--- a/include/sfx2/docinf.hxx
+++ b/include/sfx2/docinf.hxx
@@ -43,7 +43,7 @@ namespace sfx2 {
     @param  i_pStorage      OLE Storage
  */
 sal_uInt32 SFX2_DLLPUBLIC LoadOlePropertySet(
-    css::uno::Reference< css::document::XDocumentProperties> i_xDocProps,
+    const css::uno::Reference< css::document::XDocumentProperties>& i_xDocProps,
     SotStorage* i_pStorage );
 
 /** save document meta-data to OLE stream
@@ -55,7 +55,7 @@ sal_uInt32 SFX2_DLLPUBLIC LoadOlePropertySet(
     @param  i_pHyperlinks   Blob: Hyperlink blob ("_PID_HLINKS")
  */
 bool SFX2_DLLPUBLIC SaveOlePropertySet(
-    css::uno::Reference< css::document::XDocumentProperties> i_xDocProps,
+    const css::uno::Reference< css::document::XDocumentProperties>& i_xDocProps,
     SotStorage* i_pStorage,
     const css::uno::Sequence<sal_uInt8> * i_pThumb = nullptr,
     const css::uno::Sequence<sal_uInt8> * i_pGuid = nullptr,
diff --git a/include/sfx2/fcontnr.hxx b/include/sfx2/fcontnr.hxx
index 94a3e2eef2cd..d7a783411c8f 100644
--- a/include/sfx2/fcontnr.hxx
+++ b/include/sfx2/fcontnr.hxx
@@ -92,7 +92,7 @@ public:
                         SfxFilterMatcher(const SfxFilterMatcher&) = delete;
     SfxFilterMatcher&   operator=( const SfxFilterMatcher& ) = delete;
 
-    SAL_DLLPRIVATE static bool IsFilterInstalled_Impl( std::shared_ptr<const SfxFilter> pFilter );
+    SAL_DLLPRIVATE static bool IsFilterInstalled_Impl( const std::shared_ptr<const SfxFilter>& pFilter );
     DECL_DLLPRIVATE_LINK_TYPED( MaybeFileHdl_Impl, OUString*, bool );
 
     sal_uInt32               GuessFilterIgnoringContent( SfxMedium& rMedium, std::shared_ptr<const SfxFilter>& ) const;
diff --git a/include/sfx2/filedlghelper.hxx b/include/sfx2/filedlghelper.hxx
index 9e49d1d24794..7bae388ab20d 100644
--- a/include/sfx2/filedlghelper.hxx
+++ b/include/sfx2/filedlghelper.hxx
@@ -250,7 +250,7 @@ ErrCode FileOpenDialog_Impl( sal_Int16 nDialogType,
                              const css::uno::Sequence< OUString >& rBlackList = css::uno::Sequence< OUString >());
 
 
-ErrCode RequestPassword(std::shared_ptr<const SfxFilter> pCurrentFilter, OUString& aURL, SfxItemSet* pSet);
+ErrCode RequestPassword(const std::shared_ptr<const SfxFilter>& pCurrentFilter, OUString& aURL, SfxItemSet* pSet);
 }
 
 #endif
diff --git a/include/sfx2/mailmodelapi.hxx b/include/sfx2/mailmodelapi.hxx
index 911ce8f606e6..ba8285e80bd5 100644
--- a/include/sfx2/mailmodelapi.hxx
+++ b/include/sfx2/mailmodelapi.hxx
@@ -77,8 +77,8 @@ private:
     OUString            maFromAddress;
     OUString            maSubject;
 
-    static SaveResult   ShowFilterOptionsDialog( const css::uno::Reference< css::lang::XMultiServiceFactory > xSMGR,
-                                                 const css::uno::Reference< css::frame::XModel > xModel,
+    static SaveResult   ShowFilterOptionsDialog( const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR,
+                                                 const css::uno::Reference< css::frame::XModel >& xModel,
                                                  const OUString& rFilterName,
                                                  const OUString& rType,
                                                  bool bModified,
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index ccc72134f2d7..86e891cfe4b9 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -257,10 +257,10 @@ public:
     static OUString CreateShellID( const SfxObjectShell* pShell );
 
     // Document-Shell Iterator
-    static SfxObjectShell*      GetFirst( std::function<bool ( const SfxObjectShell* )> isObjectShell = nullptr,
+    static SfxObjectShell*      GetFirst( const std::function<bool ( const SfxObjectShell* )>& isObjectShell = nullptr,
                                           bool bOnlyVisible = true );
     static SfxObjectShell*      GetNext( const SfxObjectShell& rPrev,
-                                         std::function<bool ( const SfxObjectShell* )> isObjectShell = nullptr,
+                                         const std::function<bool ( const SfxObjectShell* )>& isObjectShell = nullptr,
                                          bool bOnlyVisible = true );
     static SfxObjectShell*      Current();
     static css::uno::Reference< css::uno::XInterface >
diff --git a/include/sfx2/request.hxx b/include/sfx2/request.hxx
index 1f7d9023c99e..1e07c7658caf 100644
--- a/include/sfx2/request.hxx
+++ b/include/sfx2/request.hxx
@@ -50,7 +50,7 @@ friend struct SfxRequest_Impl;
 
 public:
     SAL_DLLPRIVATE void Record_Impl( SfxShell &rSh, const SfxSlot &rSlot,
-                                     css::uno::Reference< css::frame::XDispatchRecorder > xRecorder,
+                                     const css::uno::Reference< css::frame::XDispatchRecorder >& xRecorder,
                                      SfxViewFrame* );
 private:
     SAL_DLLPRIVATE void Done_Impl( const SfxItemSet *pSet );
diff --git a/include/sfx2/sidebar/ResourceManager.hxx b/include/sfx2/sidebar/ResourceManager.hxx
index 01695ec8df8d..3cf0df998333 100644
--- a/include/sfx2/sidebar/ResourceManager.hxx
+++ b/include/sfx2/sidebar/ResourceManager.hxx
@@ -49,7 +49,7 @@ public:
     const PanelDescriptor* GetPanelDescriptor(const OUString& rsPanelId) const;
     PanelDescriptor* GetPanelDescriptor(const OUString& rsPanelId);
 
-    void UpdateModel(css::uno::Reference<css::frame::XModel> xModel);
+    void UpdateModel(const css::uno::Reference<css::frame::XModel>& xModel);
 
     void InitDeckContext(const Context& rContex);
     void SaveDecksSettings(const Context& rContext);
diff --git a/include/sfx2/sidebar/SidebarController.hxx b/include/sfx2/sidebar/SidebarController.hxx
index 00f0bab35d05..c968feced170 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -85,9 +85,9 @@ public:
     static SidebarController* GetSidebarControllerForFrame (
         const css::uno::Reference<css::frame::XFrame>& rxFrame);
 
-    static void registerSidebarForFrame(SidebarController* pController, css::uno::Reference<css::frame::XController> xFrame);
+    static void registerSidebarForFrame(SidebarController* pController, const css::uno::Reference<css::frame::XController>& xFrame);
 
-    static void unregisterSidebarForFrame(SidebarController* pController, css::uno::Reference<css::frame::XController> xFrame);
+    static void unregisterSidebarForFrame(SidebarController* pController, const css::uno::Reference<css::frame::XController>& xFrame);
 
     // ui::XContextChangeEventListener
     virtual void SAL_CALL notifyContextChangeEvent (const css::ui::ContextChangeEventObject& rEvent)
@@ -159,7 +159,7 @@ public:
 
     void notifyDeckTitle(const OUString& targetDeckId);
 
-    void updateModel(css::uno::Reference<css::frame::XModel> xModel);
+    void updateModel(const css::uno::Reference<css::frame::XModel>& xModel);
 
     void disposeDecks();
 
@@ -228,7 +228,7 @@ private:
         vcl::Window* pParentWindow,
         const bool bIsInitiallyExpanded,
         const Context& rContext,
-        VclPtr<Deck> pDeck);
+        const VclPtr<Deck>& pDeck);
 
     void SwitchToDeck (
         const DeckDescriptor& rDeckDescriptor,
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 1709b8699099..53dcd84115ae 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -169,10 +169,10 @@ protected:
 
 public:
     // Iteration
-    static SfxViewShell*        GetFirst( bool bOnlyVisible = true, std::function<bool ( const SfxViewShell* )> isViewShell = nullptr );
+    static SfxViewShell*        GetFirst( bool bOnlyVisible = true, const std::function<bool ( const SfxViewShell* )>& isViewShell = nullptr );
     static SfxViewShell*        GetNext( const SfxViewShell& rPrev,
                                          bool bOnlyVisible = true,
-                                         std::function<bool ( const SfxViewShell* )> isViewShell = nullptr );
+                                         const std::function<bool ( const SfxViewShell* )>& isViewShell = nullptr );
     static SfxViewShell*        Current();
 
     static SfxViewShell*        Get( const css::uno::Reference< css::frame::XController>& i_rController );