diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-16 08:59:52 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-16 09:10:16 +0000 |
| commit | 7cca2c7fb328e64f1779993b60809eff6974b970 (patch) | |
| tree | 1e9463b671572a0ea0d04f443033b9eaf8933bcc /include/sfx2 | |
| parent | 3c73942c8c4b97ee9ede65890e1b1db3cac753c5 (diff) | |
new loplugin finalprotected
look for final classes, and make sure they don't have protected members
Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/sfx2')
| -rw-r--r-- | include/sfx2/dispatch.hxx | 11 | ||||
| -rw-r--r-- | include/sfx2/emojiview.hxx | 2 | ||||
| -rw-r--r-- | include/sfx2/templatelocalview.hxx | 2 |
3 files changed, 6 insertions, 9 deletions
diff --git a/include/sfx2/dispatch.hxx b/include/sfx2/dispatch.hxx index 1b79d9049997..78dc67ea5f47 100644 --- a/include/sfx2/dispatch.hxx +++ b/include/sfx2/dispatch.hxx @@ -80,12 +80,15 @@ class SFX2_DLLPUBLIC SfxDispatcher final { std::unique_ptr<SfxDispatcher_Impl> xImp; -private: // Search for temporary evaluated Todos SAL_DLLPRIVATE bool CheckVirtualStack( const SfxShell& rShell ); friend class SfxApplication; friend class SfxViewFrame; +friend class SfxBindings; +friend class SfxStateCache; +friend class SfxPopupMenuManager; +friend class SfxHelp; DECL_DLLPRIVATE_LINK( EventHdl_Impl, Idle *, void ); DECL_DLLPRIVATE_LINK( PostMsgHandler, SfxRequest *, void ); @@ -93,11 +96,6 @@ friend class SfxViewFrame; SAL_DLLPRIVATE void Call_Impl( SfxShell& rShell, const SfxSlot &rSlot, SfxRequest &rReq, bool bRecord ); SAL_DLLPRIVATE void Update_Impl_( bool,bool,bool,SfxWorkWindow*); -protected: -friend class SfxBindings; -friend class SfxStateCache; -friend class SfxPopupMenuManager; -friend class SfxHelp; bool FindServer_( sal_uInt16 nId, SfxSlotServer &rServer, bool bModal ); bool FillState_( const SfxSlotServer &rServer, @@ -106,7 +104,6 @@ friend class SfxHelp; SfxRequest &rReq, SfxCallMode eCall = SfxCallMode::RECORD); -protected: void FlushImpl(); public: diff --git a/include/sfx2/emojiview.hxx b/include/sfx2/emojiview.hxx index 80ef8a0c0c36..602fae9e9ec9 100644 --- a/include/sfx2/emojiview.hxx +++ b/include/sfx2/emojiview.hxx @@ -48,7 +48,7 @@ public: static bool isFilteredCategory(FILTER_CATEGORY filter, const OUString &rCategory); -protected: +private: FILTER_CATEGORY mCategory; }; diff --git a/include/sfx2/templatelocalview.hxx b/include/sfx2/templatelocalview.hxx index 4a1579fa9190..8a3bfaeac19d 100644 --- a/include/sfx2/templatelocalview.hxx +++ b/include/sfx2/templatelocalview.hxx @@ -66,7 +66,7 @@ public: static bool isFilteredExtension(FILTER_APPLICATION filter, const OUString &rExt); bool isValid (const OUString& rPath) const; -protected: +private: FILTER_APPLICATION mApp; }; |