Generally better to have DLLPUBLIC class with some DLLPRIVATE members

...than the other way around an implicitly DLLPRIVATE class with some DLLPUBLIC
members, so that any symbols implicitly added by the compiler have the right
visibility (e.g., RTTI as needed by -fsanitize=function).

Change-Id: I4898dee0ccc6fdc4e7e1f3fb19db94661563444f

1 files changed, 10 insertions, 10 deletions

diff --git a/include/svl/inethist.hxx b/include/svl/inethist.hxx
index 96e728a2fecd..91964f8d4efe 100644
--- a/include/svl/inethist.hxx
+++ b/include/svl/inethist.hxx
@@ -25,9 +25,9 @@
 #include <tools/urlobj.hxx>
 
 class INetURLHistory_Impl;
-class INetURLHistory : public SfxBroadcaster
+class SVL_DLLPUBLIC INetURLHistory : public SfxBroadcaster
 {
-    struct StaticInstance
+    struct SAL_DLLPRIVATE StaticInstance
     {
         INetURLHistory * operator()();
     };
@@ -39,25 +39,25 @@ class INetURLHistory : public SfxBroadcaster
 
     /** Construction/Destruction.
     */
-    INetURLHistory (void);
-    virtual ~INetURLHistory (void);
+    SAL_DLLPRIVATE INetURLHistory (void);
+    SAL_DLLPRIVATE virtual ~INetURLHistory (void);
 
     /** Implementation.
     */
-    static void NormalizeUrl_Impl (INetURLObject &rUrl);
+    SAL_DLLPRIVATE static void NormalizeUrl_Impl (INetURLObject &rUrl);
 
-    SVL_DLLPUBLIC void PutUrl_Impl   (const INetURLObject &rUrl);
-    SVL_DLLPUBLIC bool QueryUrl_Impl (const INetURLObject &rUrl);
+    void PutUrl_Impl   (const INetURLObject &rUrl);
+    bool QueryUrl_Impl (const INetURLObject &rUrl);
 
     /** Not implemented.
     */
-    INetURLHistory (const INetURLHistory&);
-    INetURLHistory& operator= (const INetURLHistory&);
+    SAL_DLLPRIVATE INetURLHistory (const INetURLHistory&);
+    SAL_DLLPRIVATE INetURLHistory& operator= (const INetURLHistory&);
 
 public:
     /** GetOrCreate.
     */
-    SVL_DLLPUBLIC static INetURLHistory* GetOrCreate (void);
+    static INetURLHistory* GetOrCreate (void);
 
     /** QueryProtocol.
     */