diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-15 09:17:14 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-15 09:30:05 +0200 |
| commit | 538635e089cac31ddf433f650e86de5e2b7f03cc (patch) | |
| tree | 1f0e246954203f0d480e5ec61c049feec0ec76f1 /include/svtools | |
| parent | c3c4ae5fdac0341f01eeed8d5c633d203eed8b2a (diff) | |
Make OGenericUnoDialog::destoryDialog non-virtual
...it is only ever called:
* either from dtors, where the virtual-ness doesn't acutally help (and would
trigger loplugin:fragiledestructor if that were enabled)
* or, in module filter, from executeDialog members of (final) classes directly
derived from OGenericUnODialog without overriding destroyDialog
Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
Diffstat (limited to 'include/svtools')
| -rw-r--r-- | include/svtools/genericunodialog.hxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/svtools/genericunodialog.hxx b/include/svtools/genericunodialog.hxx index 53885eddda96..025107bef43a 100644 --- a/include/svtools/genericunodialog.hxx +++ b/include/svtools/genericunodialog.hxx @@ -121,8 +121,8 @@ namespace svt */ virtual VclPtr<Dialog> createDialog(vcl::Window* _pParent) = 0; - /// called to destroy the dialog used. the default implementation just deletes m_pDialog and resets it to NULL - virtual void destroyDialog(); + /// called to destroy the dialog used. deletes m_pDialog and resets it to NULL + void destroyDialog(); /** called after the dialog has been executed @param _nExecutionResult the execution result as returned by Dialog::Execute |