loplugin:passstuffbyref in svtools

Change-Id: I4e3d7d5fb6be857efc8327eb5113f874169bf778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 8 insertions, 8 deletions

diff --git a/include/svtools/brwbox.hxx b/include/svtools/brwbox.hxx
index 2100eac9e592..8fffe17108f2 100644
--- a/include/svtools/brwbox.hxx
+++ b/include/svtools/brwbox.hxx
@@ -528,7 +528,7 @@ public:
     tools::Long            GetTitleHeight() const;
 
     // access to dynamic values of cursor row
-    OUString        GetColumnTitle( sal_uInt16 nColumnId ) const;
+    const OUString &       GetColumnTitle( sal_uInt16 nColumnId ) const;
     tools::Rectangle       GetFieldRect( sal_uInt16 nColumnId ) const;
     tools::Long     GetColumnWidth( sal_uInt16 nColumnId ) const;
     sal_uInt16      GetColumnId( sal_uInt16 nPos ) const;
diff --git a/include/svtools/ctrltool.hxx b/include/svtools/ctrltool.hxx
index d70a49177f69..f8caa7efd2cd 100644
--- a/include/svtools/ctrltool.hxx
+++ b/include/svtools/ctrltool.hxx
@@ -159,7 +159,7 @@ public:
 
     std::unique_ptr<FontList> Clone() const;
 
-    OUString                GetFontMapText( const FontMetric& rFontMetric ) const;
+    const OUString &        GetFontMapText( const FontMetric& rFontMetric ) const;
 
     const OUString&         GetNormalStr() const { return maNormal; }
     const OUString&         GetItalicStr() const { return maNormalItalic; }
diff --git a/include/svtools/imagemgr.hxx b/include/svtools/imagemgr.hxx
index a2b48247f4d2..332998ed6c59 100644
--- a/include/svtools/imagemgr.hxx
+++ b/include/svtools/imagemgr.hxx
@@ -120,14 +120,14 @@ private:
     static OUString    GetDescription_Impl( const INetURLObject& rObject, bool bDetectFolder );
 
 public:
-    SVT_DLLPUBLIC static OUString GetImageId( const INetURLObject& rURL, bool bBig = false );
+    SVT_DLLPUBLIC static const OUString & GetImageId( const INetURLObject& rURL, bool bBig = false );
     SVT_DLLPUBLIC static Image  GetImage(
         const INetURLObject& rURL, bool bBig = false,
         css::uno::Reference<css::ucb::XCommandEnvironment> const & env
             = utl::UCBContentHelper::getDefaultCommandEnvironment());
-    SVT_DLLPUBLIC static OUString GetFileImageId( const INetURLObject& rURL );
+    SVT_DLLPUBLIC static const OUString & GetFileImageId( const INetURLObject& rURL );
     SVT_DLLPUBLIC static Image  GetImageNoDefault(const INetURLObject& rURL, vcl::ImageType eImageType = vcl::ImageType::Small);
-    SVT_DLLPUBLIC static OUString GetFolderImageId( const svtools::VolumeInfo& rInfo );
+    SVT_DLLPUBLIC static const OUString & GetFolderImageId( const svtools::VolumeInfo& rInfo );
 
     SVT_DLLPUBLIC static OUString GetDescription( const INetURLObject& rObject );
     SVT_DLLPUBLIC static OUString GetFileDescription( const INetURLObject& rObject );
diff --git a/include/svtools/tabbar.hxx b/include/svtools/tabbar.hxx
index 335779bdaef3..5b87858067f9 100644
--- a/include/svtools/tabbar.hxx
+++ b/include/svtools/tabbar.hxx
@@ -376,7 +376,7 @@ private:
 
 protected:
     virtual void AddTabClick();
-    OUString     GetAuxiliaryText(sal_uInt16 nPageId) const; // needed in derived class LayerTabBar
+    const OUString & GetAuxiliaryText(sal_uInt16 nPageId) const; // needed in derived class LayerTabBar
     void         SetAuxiliaryText(sal_uInt16 nPageId, const OUString& rText );
 
 public:
@@ -477,7 +477,7 @@ public:
     void            EndSwitchPage();
 
     virtual void    SetPageText( sal_uInt16 nPageId, const OUString& rText );
-    OUString        GetPageText( sal_uInt16 nPageId ) const;
+    const OUString & GetPageText( sal_uInt16 nPageId ) const;
     OUString        GetHelpText( sal_uInt16 nPageId ) const;
 
     tools::Long            GetSplitSize() const { return mnSplitSize; }
diff --git a/include/svtools/valueset.hxx b/include/svtools/valueset.hxx
index a132d80f2a60..2a51c19d0990 100644
--- a/include/svtools/valueset.hxx
+++ b/include/svtools/valueset.hxx
@@ -356,7 +356,7 @@ public:
     void            SetItemData( sal_uInt16 nItemId, void* pData );
     void*           GetItemData( sal_uInt16 nItemId ) const;
     void            SetItemText( sal_uInt16 nItemId, const OUString& rStr );
-    OUString        GetItemText( sal_uInt16 nItemId ) const;
+    const OUString & GetItemText( sal_uInt16 nItemId ) const;
     void            SetColor( const Color& rColor );
     void            SetColor()
     {