diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2015-11-26 15:12:20 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2015-11-28 08:44:45 +0100 |
| commit | 2283dd0b0a5117fb7b875bf97742f81820f6a1e0 (patch) | |
| tree | f814e35734727e57678885787f166aa69ee8044e /include/svx/pageitem.hxx | |
| parent | a6608ad5821710092ad92a115f74a9a98da539c3 (diff) | |
Non-implicit virtual SvxPageItem dtor
...otherwise, as the class is SVX_DLLPUBLIC and---for better or worse---
SVX_DLLPUBLIC is shared between Library_svxcore and Library_svx, all .cxx in
Library_svxcore that happen to include svx/pageitem.hxx would emit it (as well
as those in Library_svx, of course). But at least clang-cl at /O0 would want
to put SvxPageItem's (base-class) vtable in place in the dtor, so would also
emit the vtable, so would depend on SvxPageItem::operator==, but that is defined
in pageitem.cxx in Library_svx, against which Library_svxcore doesn't link.
Change-Id: Ibfc393c1de3e0bd6621c057d88b1b0f272820154
Diffstat (limited to 'include/svx/pageitem.hxx')
| -rw-r--r-- | include/svx/pageitem.hxx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/svx/pageitem.hxx b/include/svx/pageitem.hxx index 0a2b0c3f4257..988c0398e767 100644 --- a/include/svx/pageitem.hxx +++ b/include/svx/pageitem.hxx @@ -72,6 +72,8 @@ public: SvxPageItem( const sal_uInt16 nId ); SvxPageItem( const SvxPageItem& rItem ); + virtual ~SvxPageItem(); + virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; virtual bool operator==( const SfxPoolItem& ) const override; |