diff options
| author | Caolán McNamara <caolan.mcnamara@collabora.com> | 2024-06-04 09:48:57 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2024-06-05 16:56:55 +0200 |
| commit | 367ba88092fbc0ba06a7f77157cd012ff0fe3caf (patch) | |
| tree | e727f2f3494c547776d5ec2d73e03a2c88dc7cc3 /include/svx/xflboxy.hxx | |
| parent | 4cd2737d829e8a3413ad3d60a17dded4dcc8938c (diff) | |
Related: tdf#153008 bump XFillBmpPosOffsetXItem to sal_Int32
and XFillBmpPosOffsetYItem. To avoid sal_uInt16 overflows on large input
values.
Lets use sal_Int32 instead of sal_uInt32 given the amount of existing
casting to sal_Int32 of XFillBmpPosOffset[X|Y]Item::GetValue()
Change-Id: I8329c11b75c9ad01011e10130257963737ffe553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168398
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'include/svx/xflboxy.hxx')
| -rw-r--r-- | include/svx/xflboxy.hxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/svx/xflboxy.hxx b/include/svx/xflboxy.hxx index 54d354b52268..acc8fb7fdea7 100644 --- a/include/svx/xflboxy.hxx +++ b/include/svx/xflboxy.hxx @@ -23,10 +23,10 @@ #include <svl/intitem.hxx> #include <svx/svxdllapi.h> -class SVXCORE_DLLPUBLIC XFillBmpPosOffsetXItem final : public SfxUInt16Item +class SVXCORE_DLLPUBLIC XFillBmpPosOffsetXItem final : public SfxInt32Item { public: - XFillBmpPosOffsetXItem( sal_uInt16 nOffPosX = 0 ); + XFillBmpPosOffsetXItem( sal_Int32 nOffPosX = 0 ); SVX_DLLPRIVATE virtual XFillBmpPosOffsetXItem* Clone( SfxItemPool* pPool = nullptr ) const override; @@ -36,10 +36,10 @@ public: OUString &rText, const IntlWrapper& ) const override; }; -class SVXCORE_DLLPUBLIC XFillBmpPosOffsetYItem final : public SfxUInt16Item +class SVXCORE_DLLPUBLIC XFillBmpPosOffsetYItem final : public SfxInt32Item { public: - XFillBmpPosOffsetYItem( sal_uInt16 nOffPosY = 0 ); + XFillBmpPosOffsetYItem( sal_Int32 nOffPosY = 0 ); SVX_DLLPRIVATE virtual XFillBmpPosOffsetYItem* Clone( SfxItemPool* pPool = nullptr ) const override; |