loplugin:passstuffbyref improved return in svx

Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30
Reviewed-on: https://gerrit.libreoffice.org/47150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

14 files changed, 21 insertions, 21 deletions

diff --git a/include/svx/ClassificationField.hxx b/include/svx/ClassificationField.hxx
index 53989f868fc8..3eb4955dd1f1 100644
--- a/include/svx/ClassificationField.hxx
+++ b/include/svx/ClassificationField.hxx
@@ -44,7 +44,7 @@ public:
     }
 
     /// Returns the text to display, which is the Abbreviated Name, if provided, otherwise Name.
-    OUString getDisplayText() const
+    OUString const & getDisplayText() const
     {
         return !msAbbreviatedName.isEmpty() ? msAbbreviatedName : msName;
     }
diff --git a/include/svx/EnhancedCustomShapeFunctionParser.hxx b/include/svx/EnhancedCustomShapeFunctionParser.hxx
index 828a4ef4251b..bc1d97bd5879 100644
--- a/include/svx/EnhancedCustomShapeFunctionParser.hxx
+++ b/include/svx/EnhancedCustomShapeFunctionParser.hxx
@@ -233,7 +233,7 @@ public:
         @return the generated function object.
        */
 
-    SVX_DLLPUBLIC static std::shared_ptr<ExpressionNode> parseFunction( const OUString& rFunction, const EnhancedCustomShape2d& rCustoShape );
+    SVX_DLLPUBLIC static std::shared_ptr<ExpressionNode> const & parseFunction( const OUString& rFunction, const EnhancedCustomShape2d& rCustoShape );
 
     // this is a singleton
     FunctionParser() = delete;
diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx
index f9655b28bc27..8ffbc12db77f 100644
--- a/include/svx/colorbox.hxx
+++ b/include/svx/colorbox.hxx
@@ -46,7 +46,7 @@ private:
     void Selected(const NamedColor& rNamedColor);
     void createColorWindow();
     void LockWidthRequest();
-    VclPtr<SvxColorWindow> getColorWindow() const;
+    VclPtr<SvxColorWindow> const & getColorWindow() const;
 public:
     SvxColorListBox(vcl::Window* pParent, WinBits nStyle = 0);
     virtual ~SvxColorListBox() override;
@@ -59,8 +59,8 @@ public:
 
     void SetSlotId(sal_uInt16 nSlotId, bool bShowNoneButton = false);
 
-    Color GetSelectEntryColor() const { return m_aSelectedColor.first; }
-    NamedColor GetSelectedEntry() const { return m_aSelectedColor; }
+    Color const & GetSelectEntryColor() const { return m_aSelectedColor.first; }
+    NamedColor const & GetSelectedEntry() const { return m_aSelectedColor; }
 
     void SelectEntry(const NamedColor& rColor);
     void SelectEntry(const Color& rColor);
diff --git a/include/svx/dataaccessdescriptor.hxx b/include/svx/dataaccessdescriptor.hxx
index 4a810a5950f2..e66e96513356 100644
--- a/include/svx/dataaccessdescriptor.hxx
+++ b/include/svx/dataaccessdescriptor.hxx
@@ -79,7 +79,7 @@ namespace svx
             <p>If you call this method more than once, without writing any values between both calls, the same object
             is returned. If you wrote values, a new object is returned.</p>
         */
-        css::uno::Sequence< css::beans::PropertyValue >
+        css::uno::Sequence< css::beans::PropertyValue > const &
                     createPropertyValueSequence();
 
         /** initialized the descriptor from the property values given
diff --git a/include/svx/dlgctl3d.hxx b/include/svx/dlgctl3d.hxx
index 7e78d6e33d78..6bcece170214 100644
--- a/include/svx/dlgctl3d.hxx
+++ b/include/svx/dlgctl3d.hxx
@@ -59,7 +59,7 @@ public:
 
     virtual void SetObjectType(SvxPreviewObjectType nType);
     SvxPreviewObjectType GetObjectType() const { return mnObjectType; }
-    SfxItemSet Get3DAttributes() const;
+    SfxItemSet const & Get3DAttributes() const;
     virtual void Set3DAttributes(const SfxItemSet& rAttr);
 };
 
diff --git a/include/svx/sdr/attribute/sdrformtextattribute.hxx b/include/svx/sdr/attribute/sdrformtextattribute.hxx
index b5e49bc02f7b..6fe6b31164e3 100644
--- a/include/svx/sdr/attribute/sdrformtextattribute.hxx
+++ b/include/svx/sdr/attribute/sdrformtextattribute.hxx
@@ -71,7 +71,7 @@ namespace drawinglayer
             XFormTextStyle getFormTextStyle() const;
             XFormTextAdjust getFormTextAdjust() const;
             XFormTextShadow getFormTextShadow() const;
-            Color getFormTextShdwColor() const;
+            Color const & getFormTextShdwColor() const;
             const SdrFormTextOutlineAttribute& getOutline() const;
             const SdrFormTextOutlineAttribute& getShadowOutline() const;
             bool getFormTextMirror() const;
diff --git a/include/svx/sdrpagewindow.hxx b/include/svx/sdrpagewindow.hxx
index ca55b110c2d1..9407c7eed60f 100644
--- a/include/svx/sdrpagewindow.hxx
+++ b/include/svx/sdrpagewindow.hxx
@@ -61,10 +61,10 @@ public:
     SdrPageView& GetPageView() const;
     SdrPaintWindow& GetPaintWindow() const;
     const SdrPaintWindow* GetOriginalPaintWindow() const;
-    css::uno::Reference<css::awt::XControlContainer> GetControlContainer( bool _bCreateIfNecessary = true ) const;
+    css::uno::Reference<css::awt::XControlContainer> const & GetControlContainer( bool _bCreateIfNecessary = true ) const;
 
     // OVERLAYMANAGER
-    rtl::Reference< sdr::overlay::OverlayManager > GetOverlayManager() const;
+    rtl::Reference< sdr::overlay::OverlayManager > const & GetOverlayManager() const;
 
     // #i72752# allow patcing SdrPaintWindow from SdrPageView::DrawLayer if needed
     void patchPaintWindow(SdrPaintWindow& rPaintWindow);
diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx
index b670782d3137..0f725547033c 100644
--- a/include/svx/svdmrkv.hxx
+++ b/include/svx/svdmrkv.hxx
@@ -239,9 +239,9 @@ public:
     size_t GetMarkedObjectCount() const { return GetMarkedObjectList().GetMarkCount(); }
     void SortMarkedObjects() const { GetMarkedObjectList().ForceSort(); }
     bool AreObjectsMarked() const { return 0 != GetMarkedObjectList().GetMarkCount(); }
-    OUString GetDescriptionOfMarkedObjects() const { return GetMarkedObjectList().GetMarkDescription(); }
-    OUString GetDescriptionOfMarkedPoints() const { return GetMarkedObjectList().GetPointMarkDescription(); }
-    OUString GetDescriptionOfMarkedGluePoints() const { return GetMarkedObjectList().GetGluePointMarkDescription(); }
+    OUString const & GetDescriptionOfMarkedObjects() const { return GetMarkedObjectList().GetMarkDescription(); }
+    OUString const & GetDescriptionOfMarkedPoints() const { return GetMarkedObjectList().GetPointMarkDescription(); }
+    OUString const & GetDescriptionOfMarkedGluePoints() const { return GetMarkedObjectList().GetGluePointMarkDescription(); }
 
     // Get a list of all those links which are connected to marked nodes,
     // but which are not marked themselves.
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index 74cb44b022db..b4fd3baba256 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -157,7 +157,7 @@ public:
     const Size&             GetGrafPrefSize() const;
 
     void                    SetGrafStreamURL( const OUString& rGraphicStreamURL );
-    OUString                GetGrafStreamURL() const;
+    OUString const &        GetGrafStreamURL() const;
     Size                    getOriginalSize() const;
 
 private:
@@ -272,7 +272,7 @@ public:
         mbIsSignatureLineCanAddComment = bIsSignatureCanAddComment;
     };
     bool isSignatureLineCanAddComment() const { return mbIsSignatureLineCanAddComment; };
-    const css::uno::Reference<css::graphic::XGraphic> getSignatureLineUnsignedGraphic() const
+    css::uno::Reference<css::graphic::XGraphic> const & getSignatureLineUnsignedGraphic() const
     {
         return mpSignatureLineUnsignedGraphic;
     };
diff --git a/include/svx/svdomedia.hxx b/include/svx/svdomedia.hxx
index 27d113cf9ee9..f0bf09300aff 100644
--- a/include/svx/svdomedia.hxx
+++ b/include/svx/svdomedia.hxx
@@ -63,7 +63,7 @@ public:
         void                        setMediaProperties( const ::avmedia::MediaItem& rState );
         const ::avmedia::MediaItem& getMediaProperties() const;
 
-        const css::uno::Reference< css::graphic::XGraphic >
+        css::uno::Reference< css::graphic::XGraphic > const &
                                     getSnapshot() const;
         css::uno::Reference< css::io::XInputStream>
                                     GetInputStream();
diff --git a/include/svx/svdoole2.hxx b/include/svx/svdoole2.hxx
index 34c31c4590ba..4da4d057efb8 100644
--- a/include/svx/svdoole2.hxx
+++ b/include/svx/svdoole2.hxx
@@ -105,9 +105,9 @@ public:
     bool IsEmpty() const;
 
     void SetObjRef(const css::uno::Reference < css::embed::XEmbeddedObject >& rNewObjRef);
-    css::uno::Reference < css::embed::XEmbeddedObject > GetObjRef() const;
+    css::uno::Reference < css::embed::XEmbeddedObject > const & GetObjRef() const;
 
-    SVX_DLLPRIVATE css::uno::Reference < css::embed::XEmbeddedObject > GetObjRef_NoInit() const;
+    SVX_DLLPRIVATE css::uno::Reference < css::embed::XEmbeddedObject > const & GetObjRef_NoInit() const;
 
     void AbandonObject();
 
diff --git a/include/svx/tbxcolorupdate.hxx b/include/svx/tbxcolorupdate.hxx
index 5fad1c3dc759..8d0d3abbed96 100644
--- a/include/svx/tbxcolorupdate.hxx
+++ b/include/svx/tbxcolorupdate.hxx
@@ -47,7 +47,7 @@ namespace svx
                     ~ToolboxButtonColorUpdater();
 
         void        Update( const Color& rColor, bool bForceUpdate = false );
-        Color       GetCurrentColor() const { return maCurColor; }
+        Color const & GetCurrentColor() const { return maCurColor; }
 
     private:
         ToolboxButtonColorUpdater(ToolboxButtonColorUpdater &) = delete;
diff --git a/include/svx/unoshape.hxx b/include/svx/unoshape.hxx
index 2e81df0ea8af..eec731fbe971 100644
--- a/include/svx/unoshape.hxx
+++ b/include/svx/unoshape.hxx
@@ -228,7 +228,7 @@ public:
 
     // access methods for master objects
     /// @throws css::uno::RuntimeException
-    css::uno::Reference< css::beans::XPropertySetInfo > _getPropertySetInfo(  );
+    css::uno::Reference< css::beans::XPropertySetInfo > const & _getPropertySetInfo(  );
     /// @throws css::beans::UnknownPropertyException
     /// @throws css::beans::PropertyVetoException
     /// @throws css::lang::IllegalArgumentException
diff --git a/include/svx/xit.hxx b/include/svx/xit.hxx
index 540ffa403eff..4630fa7f221a 100644
--- a/include/svx/xit.hxx
+++ b/include/svx/xit.hxx
@@ -51,7 +51,7 @@ public:
     virtual bool         operator==(const SfxPoolItem& rItem) const override;
     virtual SfxPoolItem* Clone(SfxItemPool* pPool = nullptr) const override;
 
-            OUString     GetName() const              { return GetValue();   }
+            OUString const & GetName() const              { return GetValue();   }
             void         SetName(const OUString& rName) { SetValue(rName);     }
             bool         IsIndex() const          { return (nPalIndex >= 0); }