diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2019-03-15 11:19:51 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2019-03-16 01:01:33 +0100 |
| commit | e3e6f43bc8c01ca6c3ad87180db2b3e623d8eed4 (patch) | |
| tree | 6a3f041c5073bc05e21ff3d1e4f0b194ba655df3 /include/svx | |
| parent | 8a8c029244e8a27efd92017968313c2116a9776a (diff) | |
clarify that set_visible(true/false) is just show/hide
ditch duplicate method
Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b
Reviewed-on: https://gerrit.libreoffice.org/69302
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'include/svx')
| -rw-r--r-- | include/svx/colorbox.hxx | 8 | ||||
| -rw-r--r-- | include/svx/frmdirlbox.hxx | 3 | ||||
| -rw-r--r-- | include/svx/langbox.hxx | 2 |
3 files changed, 4 insertions, 9 deletions
diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx index ab79efd8b5df..a9b38b7612ba 100644 --- a/include/svx/colorbox.hxx +++ b/include/svx/colorbox.hxx @@ -138,13 +138,7 @@ public: bool get_sensitive() const { return m_xButton->get_sensitive(); } void show() { m_xButton->show(); } void hide() { m_xButton->hide(); } - void show(bool bShow) - { - if (bShow) - show(); - else - hide(); - } + void set_visible(bool bShow) { m_xButton->set_visible(bShow); } void set_help_id(const OString& rHelpId) { m_xButton->set_help_id(rHelpId); } weld::MenuButton& get_widget() { return *m_xButton; } }; diff --git a/include/svx/frmdirlbox.hxx b/include/svx/frmdirlbox.hxx index cb2e1452fbba..c1cd4b376869 100644 --- a/include/svx/frmdirlbox.hxx +++ b/include/svx/frmdirlbox.hxx @@ -50,7 +50,8 @@ public: int get_active() const { return m_xControl->get_active(); } void set_sensitive(bool bSensitive) { m_xControl->set_sensitive(bSensitive); } void hide() { m_xControl->hide(); } - void show(bool bShow = true) { m_xControl->show(bShow); } + void set_visible(bool bVisible) { m_xControl->set_visible(bVisible); } + void show() { m_xControl->show(); } int get_count() const { return m_xControl->get_count(); } /** Inserts a string with corresponding direction enum into the listbox. */ void append(SvxFrameDirection eDirection, const OUString& rString) diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx index 723faf6e02b4..e20c35a96adf 100644 --- a/include/svx/langbox.hxx +++ b/include/svx/langbox.hxx @@ -162,7 +162,7 @@ public: bool get_active_id_changed_from_saved() const { return m_eSavedLanguage != get_active_id(); } void show() { m_xControl->show(); } void hide() { m_xControl->hide(); } - void show(bool bShow) { if (bShow) show(); else hide(); } + void set_visible(bool bShow) { m_xControl->set_visible(bShow); } void set_sensitive(bool bSensitive) { m_xControl->set_sensitive(bSensitive); } void set_active(int nPos) { m_xControl->set_active(nPos); } int get_active() const { return m_xControl->get_active(); } |