new loplugin finalprotected

look for final classes, and make sure they don't have protected members

Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 4 insertions, 12 deletions

diff --git a/include/svx/AccessibleTextHelper.hxx b/include/svx/AccessibleTextHelper.hxx
index c264585846e8..7fdee91520de 100644
--- a/include/svx/AccessibleTextHelper.hxx
+++ b/include/svx/AccessibleTextHelper.hxx
@@ -126,14 +126,9 @@ namespace accessibility
 
         ~AccessibleTextHelper();
 
-    protected:
+        AccessibleTextHelper( const AccessibleTextHelper& ) = delete;
+        AccessibleTextHelper& operator= ( const AccessibleTextHelper& ) = delete;
 
-        // declared, but not defined
-        AccessibleTextHelper( const AccessibleTextHelper& );
-        // declared, but not defined
-        AccessibleTextHelper& operator= ( const AccessibleTextHelper& );
-
-    public:
         /** Query the current edit source
 
             @attention This method returns by reference, so you are
diff --git a/include/svx/ShapeTypeHandler.hxx b/include/svx/ShapeTypeHandler.hxx
index 7e21e384ed93..b2c80e3cac0b 100644
--- a/include/svx/ShapeTypeHandler.hxx
+++ b/include/svx/ShapeTypeHandler.hxx
@@ -140,7 +140,7 @@ public:
         const css::uno::Reference< css::drawing::XShape >& rxShape)
             throw (css::uno::RuntimeException, std::exception);
 
-protected:
+private:
     // Declare default constructor, copy constructor, destructor, and
     // assignment operation protected so that no one accidentally creates a
     // second instance of this singleton class or deletes it.
@@ -153,7 +153,6 @@ protected:
     */
     ~ShapeTypeHandler();
 
-private:
     /// Pointer to the only instance of this class.
     static ShapeTypeHandler* instance;
 
diff --git a/include/svx/fmsrcimp.hxx b/include/svx/fmsrcimp.hxx
index 478b9e1c1e84..467fafabbc9e 100644
--- a/include/svx/fmsrcimp.hxx
+++ b/include/svx/fmsrcimp.hxx
@@ -310,7 +310,7 @@ public:
     void SwitchToContext(const css::uno::Reference< css::sdbc::XResultSet >& xCursor, const OUString& strVisibleFields, const InterfaceArray& arrFields,
         sal_Int32 nFieldIndex);
 
-protected:
+private:
     void Init(const OUString& strVisibleFields);
 
     void SearchNextImpl();
@@ -319,7 +319,6 @@ protected:
     // start a thread-search (or call SearchNextImpl directly, depending on the search mode)
     void ImplStartNextSearch();
 
-private:
     SVX_DLLPRIVATE void clearControlTexts();
     SVX_DLLPRIVATE void fillControlTexts(const InterfaceArray& arrFields);
 
diff --git a/include/svx/sdr/contact/displayinfo.hxx b/include/svx/sdr/contact/displayinfo.hxx
index 64d15f9564bb..b474cae3377e 100644
--- a/include/svx/sdr/contact/displayinfo.hxx
+++ b/include/svx/sdr/contact/displayinfo.hxx
@@ -30,7 +30,6 @@ namespace sdr
     {
         class SVX_DLLPUBLIC DisplayInfo final
         {
-        protected:
             // The Layers which shall be processed (visible)
             SetOfByte                                       maProcessLayers;