loplugin:constantfunction in ucbhelper

Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60
Reviewed-on: https://gerrit.libreoffice.org/23297
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

5 files changed, 10 insertions, 36 deletions

diff --git a/include/ucbhelper/contenthelper.hxx b/include/ucbhelper/contenthelper.hxx
index d05f552b23b6..f558507e2d45 100644
--- a/include/ucbhelper/contenthelper.hxx
+++ b/include/ucbhelper/contenthelper.hxx
@@ -255,13 +255,10 @@ protected:
       *
       * @param  rOldKey is the old key of the propertyset.
       * @param  rNewKey is the new key for the propertyset.
-      * @param  bRecursive is a flag indicating whether propertysets for
-      *         children described by rOldKey shall be renamed too.
       * @return True, if the operation succeeded - False, otherwise.
       */
     bool renameAdditionalPropertySet( const OUString& rOldKey,
-                                          const OUString& rNewKey,
-                                          bool bRecursive );
+                                          const OUString& rNewKey );
 
     /**
       * This method copies the propertyset containing the Additional Core
@@ -269,13 +266,10 @@ protected:
       *
       * @param  rSourceKey is the key of the source propertyset.
       * @param  rTargetKey is the key of the target propertyset.
-      * @param  bRecursive is a flag indicating whether propertysets for
-      *         children described by rSourceKey shall be copied too.
       * @return True, if the operation succeeded - False, otherwise.
       */
     bool copyAdditionalPropertySet( const OUString& rSourceKey,
-                                        const OUString& rTargetKey,
-                                        bool bRecursive );
+                                        const OUString& rTargetKey );
 
     /**
       * This method removes the propertyset containing the Additional Core
diff --git a/include/ucbhelper/interactionrequest.hxx b/include/ucbhelper/interactionrequest.hxx
index 03122c18742f..08df5d700b85 100644
--- a/include/ucbhelper/interactionrequest.hxx
+++ b/include/ucbhelper/interactionrequest.hxx
@@ -399,8 +399,6 @@ public:
       * @param bCanUseSystemCredentials indicates whether issuer of the
       *        authentication request can obtain and use system credentials
       *        for authentication.
-      * @param bDefaultUseSystemCredentials specifies the default system
-      *        credentials usage preferred by the requesting client
       *
       * @see css::ucb::AuthenticationRequest
       * @see css::ucb::RememberAuthentication
@@ -415,8 +413,7 @@ public:
                     const css::ucb::RememberAuthentication eDefaultRememberPasswordMode,
                     const css::uno::Sequence< css::ucb::RememberAuthentication > & rRememberAccountModes,
                     const css::ucb::RememberAuthentication  eDefaultRememberAccountMode,
-                    bool bCanUseSystemCredentials,
-                    bool bDefaultUseSystemCredentials );
+                    bool bCanUseSystemCredentials );
 
     // XInterface
     virtual css::uno::Any SAL_CALL
@@ -568,8 +565,7 @@ inline InteractionSupplyAuthentication::InteractionSupplyAuthentication(
     const css::ucb::RememberAuthentication eDefaultRememberPasswordMode,
     const css::uno::Sequence< css::ucb::RememberAuthentication > & rRememberAccountModes,
     const css::ucb::RememberAuthentication eDefaultRememberAccountMode,
-    bool bCanUseSystemCredentials,
-    bool bDefaultUseSystemCredentials )
+    bool bCanUseSystemCredentials )
 : InteractionContinuation( pRequest ),
   m_aRememberPasswordModes( rRememberPasswordModes ),
   m_aRememberAccountModes( rRememberAccountModes ),
@@ -582,8 +578,8 @@ inline InteractionSupplyAuthentication::InteractionSupplyAuthentication(
   m_bCanSetPassword( bCanSetPassword ),
   m_bCanSetAccount( bCanSetAccount ),
   m_bCanUseSystemCredentials( bCanUseSystemCredentials ),
-  m_bDefaultUseSystemCredentials( bDefaultUseSystemCredentials ),
-  m_bUseSystemCredentials( bDefaultUseSystemCredentials && bCanUseSystemCredentials )
+  m_bDefaultUseSystemCredentials( false ),
+  m_bUseSystemCredentials( false )
 {
 }
 
diff --git a/include/ucbhelper/resultsetmetadata.hxx b/include/ucbhelper/resultsetmetadata.hxx
index 9ac6996f4a97..079a3204dae0 100644
--- a/include/ucbhelper/resultsetmetadata.hxx
+++ b/include/ucbhelper/resultsetmetadata.hxx
@@ -150,18 +150,15 @@ protected:
 public:
 
     /**
-      * Constructor.
+      * Constructor. ResultSet is readonly by default.
       *
       * @param rxSMgr is a Servive Manager.
       * @param rProps is a sequence of properties (partially) describing the
       *        columns of a resultset.
-      * @param bReadOnly is used to specify whether the whole(!) resultset
-      *        is read-only.
       */
     ResultSetMetaData(
             const css::uno::Reference< css::uno::XComponentContext >& rxContext,
-            const css::uno::Sequence< css::beans::Property >& rProps,
-            bool bReadOnly = true );
+            const css::uno::Sequence< css::beans::Property >& rProps );
 
     /**
       * Constructor.
diff --git a/include/ucbhelper/simpleauthenticationrequest.hxx b/include/ucbhelper/simpleauthenticationrequest.hxx
index 3a14090206ec..892d70ecf696 100644
--- a/include/ucbhelper/simpleauthenticationrequest.hxx
+++ b/include/ucbhelper/simpleauthenticationrequest.hxx
@@ -86,8 +86,6 @@ public:
       * @param rPassword contains a password, if available (for instance from
       *        a previous try).
       * @param rAccount contains an account, if applicable.
-      * @param bAllowPersistentStoring specifies if the credentials should
-      *        be stored in the password container persistently
       * @param bAllowUseSystemCredentials specifies if requesting client is
       *        able to obtain and use system credentials for authentication
       */
@@ -97,7 +95,6 @@ public:
                                  const OUString & rUserName,
                                  const OUString & rPassword,
                                  const OUString & rAccount,
-                                 bool bAllowPersistentStoring,
                                  bool bAllowUseSystemCredentials,
                                  bool bAllowSessionStoring = true );
 
@@ -117,9 +114,6 @@ public:
                modifiable.
       * @param rPassword contains a password, if available (for instance from
       *        a previous try).
-      * @param eAccountType specifies whether an account is applicable and
-               modifiable.
-      * @param rAccount contains an account, if applicable.
       */
     SimpleAuthenticationRequest( const OUString & rURL,
                                  const OUString & rServerName,
@@ -128,10 +122,7 @@ public:
                                  EntityType eUserNameType,
                                  const OUString & rUserName,
                                  EntityType ePasswordType,
-                                 const OUString & rPassword,
-                                 EntityType eAccountType = ENTITY_NA,
-                                 const OUString & rAccount
-                                    = OUString() );
+                                 const OUString & rPassword );
 
     /**
       * This method returns the supplier for the missing authentication data,
diff --git a/include/ucbhelper/simplenameclashresolverequest.hxx b/include/ucbhelper/simplenameclashresolverequest.hxx
index da9b761f5129..8c63126337ed 100644
--- a/include/ucbhelper/simplenameclashresolverequest.hxx
+++ b/include/ucbhelper/simplenameclashresolverequest.hxx
@@ -54,14 +54,10 @@ public:
       * @param rClashingName contains the clashing name.
       * @param rProposedNewName contains a proposal for the new name or is
       *        empty.
-      * @param bSupportsOverwriteData indicates whether an
-      *        InteractionReplaceExistingData continuation shall be supplied
-      *        with the interaction request.
       */
     SimpleNameClashResolveRequest( const OUString & rTargetFolderURL,
                                    const OUString & rClashingName,
-                                   const OUString & rProposedNewName,
-                                   bool bSupportsOverwriteData = true );
+                                   const OUString & rProposedNewName );
     /**
       * This method returns the new name that was supplied by the interaction
       * handler.