fix memory management in BitmapConvolutionMatrixFilter

was deleting a stack allocated buffer.

Also
(*) drop the BitmapConvolutionMatrixFilter default constructor, the
current code does not permit mpMatrix to be nullptr
(*) declare the mpMatrix field as a reference to a fixed length array,
to be more precise
(*) pass the array in the constructor so that call sites will be
properly type- and length-checked.

Change-Id: I650d56cdfac0dae4ea77df7c0c03e19d658c00c8
Reviewed-on: https://gerrit.libreoffice.org/53312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 5 deletions

diff --git a/include/vcl/BitmapSharpenFilter.hxx b/include/vcl/BitmapSharpenFilter.hxx
index 7e965976d5e8..66cb56f3a1d5 100644
--- a/include/vcl/BitmapSharpenFilter.hxx
+++ b/include/vcl/BitmapSharpenFilter.hxx
@@ -16,11 +16,7 @@
 class VCL_DLLPUBLIC BitmapSharpenFilter : public BitmapConvolutionMatrixFilter
 {
 public:
-    BitmapSharpenFilter()
-    {
-        const long pSharpenMatrix[] = { -1, -1, -1, -1, 16, -1, -1, -1, -1 };
-        mpMatrix = &pSharpenMatrix[0];
-    }
+    BitmapSharpenFilter();
 };
 
 #endif