diff options
| author | Tor Lillqvist <tml@collabora.com> | 2015-11-16 20:39:17 +0200 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2015-11-16 22:48:23 +0200 |
| commit | 43190248c9603a3038f2d35f825a07340ad04439 (patch) | |
| tree | 8e113261879c3d1a0a93c3479cfe9b6e9f9d2e0a /include/vcl/opengl | |
| parent | 97972153d0e221cd38e663a041f6a08752c0463c (diff) | |
If SAL_WARN() does nothing, no point in CHECK_GL_ERROR() either
Earlier, CHECK_GL_ERROR() always called OpenGLHelper::checkGLError().
That function looks up the OpenGL error status using glGetError(),
which might be a not so light-weight operation, and outputs error
information using SAL_WARN(). In a production build where SAL_WARN()
is a no-op anyway, that is fairly pointless.
Change-Id: I2d044bff6128a8ac7739020f8e414d7d3615e8d5
Diffstat (limited to 'include/vcl/opengl')
| -rw-r--r-- | include/vcl/opengl/OpenGLHelper.hxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/vcl/opengl/OpenGLHelper.hxx b/include/vcl/opengl/OpenGLHelper.hxx index 437b4350101a..6c95f18eba93 100644 --- a/include/vcl/opengl/OpenGLHelper.hxx +++ b/include/vcl/opengl/OpenGLHelper.hxx @@ -99,7 +99,11 @@ public: #endif }; +#ifdef SAL_LOG_WARN #define CHECK_GL_ERROR() OpenGLHelper::checkGLError(__FILE__, __LINE__) +#else +#define CHECK_GL_ERROR() do { } while (false) +#endif #endif |