diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-09-08 12:38:39 +0100 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-09-10 14:18:09 +0200 |
| commit | 53ebbad48c8c2a71044917a5cbac9657126e5adc (patch) | |
| tree | 32ae305d00d765b2f0d1bbb7f9bc4cefcac8cd18 /include/vcl/transfer.hxx | |
| parent | e32d864dbe086d630a8b17c2d376e320aee0253a (diff) | |
warning: Excessive padding in 'struct OutDevState'
experiment with optin.performance.Padding analyzer and tuning
AllowedPad to 2
with clang as compiler;
export ENVCFLAGSCXX="-Xclang -analyze -Xclang -analyzer-checker=optin.performance -Xclang -analyzer-config -Xclang optin.performance.Padding:AllowedPad=2"
and get a report of:
OutDevState (13 padding bytes, where 5 is optimal)
UIControlOptions (9 padding bytes, where 1 is optimal)
Change-Id: I174f6f62d6e32df057d5e0f21d4274166f6ed8c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121812
Tested-by: Jenkins
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/vcl/transfer.hxx')
| -rw-r--r-- | include/vcl/transfer.hxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/vcl/transfer.hxx b/include/vcl/transfer.hxx index 99413ad189e3..45fa55176e3a 100644 --- a/include/vcl/transfer.hxx +++ b/include/vcl/transfer.hxx @@ -90,9 +90,9 @@ struct TransferableObjectDescriptor struct AcceptDropEvent { - sal_Int8 mnAction; Point maPosPixel; const css::datatransfer::dnd::DropTargetDragEvent maDragEvent; + sal_Int8 mnAction; bool mbLeaving; bool mbDefault; @@ -104,26 +104,26 @@ struct AcceptDropEvent AcceptDropEvent( sal_Int8 nAction, const Point& rPosPixel, const css::datatransfer::dnd::DropTargetDragEvent& rDragEvent ) : - mnAction( nAction ), maPosPixel( rPosPixel ), maDragEvent( rDragEvent ), + mnAction( nAction ), mbLeaving( false ), mbDefault( false ) {} }; struct ExecuteDropEvent { - sal_Int8 mnAction; Point maPosPixel; const css::datatransfer::dnd::DropTargetDropEvent maDropEvent; + sal_Int8 mnAction; bool mbDefault; ExecuteDropEvent( sal_Int8 nAction, const Point& rPosPixel, const css::datatransfer::dnd::DropTargetDropEvent& rDropEvent ) : - mnAction( nAction ), maPosPixel( rPosPixel ), maDropEvent( rDropEvent ), + mnAction( nAction ), mbDefault( false ) {} }; |